Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-fonts-cache: remove CACHEDIR.TAG file from Nix store #34708

Closed
wants to merge 1 commit into from
Closed

make-fonts-cache: remove CACHEDIR.TAG file from Nix store #34708

wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Feb 7, 2018

Motivation for this change

A CACHEDIR.TAG file indicates that the contents can be automatically
re-generated. This is not really true for Nix store paths. (Well Nix
can recreate them, but that's different.)

I noticed this issue as I was restoring full system backup that "for
some reason" always missed /nix/store/*-fc-cache (found by nix-store --verify --repair). Turns out I was excluding caches from my backup...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
make-fonts-cache: remove CACHEDIR.TAG file from Nix store
ada36a7 
A CACHEDIR.TAG file indicates that the contents can be automatically
re-generated. This is not really true for Nix store paths. (Well _Nix_
can recreate them, but that's different.)

I noticed this issue as I was restoring full system backup that "for
some reason" always missed /nix/store/*-fc-cache (found by `nix-store
--verify --repair`). Turns out I was excluding caches from my backup...
@bjornfor
Copy link
Contributor Author

Applied to master (8ea7a30).

@bjornfor bjornfor closed this Feb 11, 2018
@bjornfor bjornfor deleted the remove-fc-cache-cachedir-tag branch February 11, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjornfor @GrahamcOfBorg