Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PICARD-1187: Add DSF file support #835

Merged
merged 2 commits into from Feb 26, 2018
Merged

PICARD-1187: Add DSF file support #835

merged 2 commits into from Feb 26, 2018

Conversation

zas
Copy link
Collaborator

@zas zas commented Feb 9, 2018 •
edited

@zas zas requested review from phw and samj1912 February 9, 2018 15:46
@zas
Copy link
Collaborator Author

zas commented Feb 9, 2018

Do not pass tests yet.

@zas
Copy link
Collaborator Author

zas commented Feb 9, 2018

@phw i'm not at ease with formats in Picard, if you can give me a hand on this ... ;)

samj1912
samj1912 approved these changes Feb 26, 2018
View reviewed changes
Copy link
Collaborator

@samj1912 samj1912 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge this PR and make an equivalent update to PW stating that DSF does not support the given tags. We can also hide these tags from display in the diff tag to prevent users from getting any misconceptions.

samj1912
samj1912 reviewed Feb 26, 2018
View reviewed changes
picard/formats/id3.py
@@ -595,6 +596,36 @@ def _info(self, metadata, file):
metadata['~format'] = self.NAME


class DSFFile(ID3File):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can over-ride the supports_tag method in the class to exclude the unsupported tags so that they don't appear in the UI.

@zas zas changed the title [experimental] PICARD-1187: Add DSF file support PICARD-1187: Add DSF file support Feb 26, 2018
@zas zas merged commit a8e416a into metabrainz:master Feb 26, 2018
@samj1912 samj1912 mentioned this pull request Feb 26, 2018
Merged
5 tasks
@zas zas deleted the dsf branch March 30, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samj1912 samj1912 samj1912 approved these changes

@phw phw Awaiting requested review from phw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zas @samj1912