Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libproxy: fix building on darwin #34765

Merged
merged 1 commit into from Feb 9, 2018
Merged

libproxy: fix building on darwin #34765

merged 1 commit into from Feb 9, 2018

Conversation

greedy
Copy link
Contributor

@greedy greedy commented Feb 9, 2018

Motivation for this change

Update libproxy to build on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Feb 9, 2018

@GrahamcOfBorg build libproxy

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/00bq3bkbchqdfs669nlad4zqrzmvs4wb-libproxy-0.4.15/lib  /nix/store/00bq3bkbchqdfs669nlad4zqrzmvs4wb-libproxy-0.4.15/bin
patching script interpreter paths in /nix/store/00bq3bkbchqdfs669nlad4zqrzmvs4wb-libproxy-0.4.15
/nix/store/00bq3bkbchqdfs669nlad4zqrzmvs4wb-libproxy-0.4.15/lib/libproxy.1.0.0.dylib: fixing dylib
/nix/store/00bq3bkbchqdfs669nlad4zqrzmvs4wb-libproxy-0.4.15/lib/libproxy.1.0.0.dylib: fixing dylib
/nix/store/00bq3bkbchqdfs669nlad4zqrzmvs4wb-libproxy-0.4.15/lib/libproxy.1.0.0.dylib: fixing dylib
/nix/store/00bq3bkbchqdfs669nlad4zqrzmvs4wb-libproxy-0.4.15/lib/libproxy.1.0.0.dylib: fixing dylib
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kflaj7kz39dy5gv8xv1c595bj98lxffi-libproxy-0.4.15-dev/lib
patching script interpreter paths in /nix/store/kflaj7kz39dy5gv8xv1c595bj98lxffi-libproxy-0.4.15-dev
/nix/store/00bq3bkbchqdfs669nlad4zqrzmvs4wb-libproxy-0.4.15

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1rqlvyam9jgbwsf4gm6g6mbmfyn7aizj-libproxy-0.4.15/lib  /nix/store/1rqlvyam9jgbwsf4gm6g6mbmfyn7aizj-libproxy-0.4.15/libexec  /nix/store/1rqlvyam9jgbwsf4gm6g6mbmfyn7aizj-libproxy-0.4.15/bin
patching script interpreter paths in /nix/store/1rqlvyam9jgbwsf4gm6g6mbmfyn7aizj-libproxy-0.4.15
checking for references to /build in /nix/store/1rqlvyam9jgbwsf4gm6g6mbmfyn7aizj-libproxy-0.4.15...
shrinking RPATHs of ELF executables and libraries in /nix/store/qm2i6i21ipi43w7409w5wpiallpx1f3l-libproxy-0.4.15-dev
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qm2i6i21ipi43w7409w5wpiallpx1f3l-libproxy-0.4.15-dev/lib
patching script interpreter paths in /nix/store/qm2i6i21ipi43w7409w5wpiallpx1f3l-libproxy-0.4.15-dev
checking for references to /build in /nix/store/qm2i6i21ipi43w7409w5wpiallpx1f3l-libproxy-0.4.15-dev...
/nix/store/1rqlvyam9jgbwsf4gm6g6mbmfyn7aizj-libproxy-0.4.15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/i5qc5icrrd0q30mw2rxapiah3a7nc5d9-libproxy-0.4.15/lib  /nix/store/i5qc5icrrd0q30mw2rxapiah3a7nc5d9-libproxy-0.4.15/libexec  /nix/store/i5qc5icrrd0q30mw2rxapiah3a7nc5d9-libproxy-0.4.15/bin 
patching script interpreter paths in /nix/store/i5qc5icrrd0q30mw2rxapiah3a7nc5d9-libproxy-0.4.15
checking for references to /tmp/nix-build-libproxy-0.4.15.drv-0 in /nix/store/i5qc5icrrd0q30mw2rxapiah3a7nc5d9-libproxy-0.4.15...
shrinking RPATHs of ELF executables and libraries in /nix/store/8n6a9syvg2ir71afd5zxcypbn6264r7v-libproxy-0.4.15-dev
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8n6a9syvg2ir71afd5zxcypbn6264r7v-libproxy-0.4.15-dev/lib 
patching script interpreter paths in /nix/store/8n6a9syvg2ir71afd5zxcypbn6264r7v-libproxy-0.4.15-dev
checking for references to /tmp/nix-build-libproxy-0.4.15.drv-0 in /nix/store/8n6a9syvg2ir71afd5zxcypbn6264r7v-libproxy-0.4.15-dev...
/nix/store/i5qc5icrrd0q30mw2rxapiah3a7nc5d9-libproxy-0.4.15

@Mic92 Mic92 merged commit 807d76b into NixOS:master Feb 9, 2018
@jtojnar jtojnar mentioned this pull request Feb 13, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greedy @Mic92 @GrahamcOfBorg