Rework logging system and in-app log view #834
Conversation
|
|
||
| def set_verbosity(self, level): | ||
| self.actions[level].setChecked(True) | ||
|
|
||
|
|
||
| class LogView(LogViewCommon): |
There was a problem hiding this comment.
I get this warning from Qt - QLayout: Attempting to add QLayout "" to LogView "", which already has a layout
should it matter?
There was a problem hiding this comment.
That's a parenting conflict, when you set explicitly a parent and Qt think different.
Too much parenting kills parenting ;)
Try to see if it is better with 5699bb1
picard/ui/logview.py
Outdated
| self.hbox.addWidget(self.save_log_as_button) | ||
| self.save_log_as_button.clicked.connect(self._save_log_as_do) | ||
|
|
||
| # ------ |
There was a problem hiding this comment.
Do we need this?
No, removed in 5699bb1
- use standard logging module as backend - implement a circular buffer handler for in-app log view - use default logging levels - debug mode is now tied to verbosity - default log format changed, adding source/lineno infos and milliseconds precision - history log changed to logging/circular buffer handler too - log view was changed accordingly - Save As button added - Clear Log (only the in-memory buffer and the view) button added, with confirmation dialog - Highlight text and button added - Verbosity toggling menu added - Debug mode check box removed (replaced by verbosity = Debug)
- if user set verbosity to debug in log view, keep this setting on next start - if -d is passed on command line, set verbosity to debug only until exit, but if the user switches it in log view - set default log level to warning - save verbosity to config option "log_verbosity"
QLayout: Attempting to add QLayout "" to LogView "", which already has a layout
|
|
||
| # copied from https://github.com/python/cpython/blob/3.5/Lib/logging/__init__.py#L1353-L1381 | ||
| # see https://stackoverflow.com/questions/4957858/how-to-write-own-logging-methods-for-own-logging-levels | ||
| def findCaller(self, stack_info=False): |
There was a problem hiding this comment.
Maybe I'm missing something, but why do we need our own copy of this method? Replacing this whole class with
class OurLogger(logging.getLoggerClass()):
passappears to result in exactly the same log messages.
Also, technically, there's a license declaration at the top of logging.py in cpython that this copy here appears to violate (but I am not a lawyer).
There was a problem hiding this comment.
It is needed, because of https://github.com/metabrainz/picard/pull/834/files#diff-5e8bcd94ca229f5652e0efe229fcfab7R105 which is using _srcfile
Just subclassing will not work in all cases, because of this. I wish there was another way, but i couldn't find one, findCaller() is just badly designed and doesn't play well with our wrapped calls.
About the license, i guess you're right, it should appear somewhere. Copying just above this block and in https://github.com/metabrainz/picard/blob/master/AUTHORS.txt should be ok, right?
There was a problem hiding this comment.
#839 removes the useless code ;)
use standard logging module as backend
implement a circular buffer handler for in-app log view
use default logging levels
debug mode is now tied to verbosity
default log format changed, adding source/lineno infos and milliseconds precision
history log changed to logging/circular buffer handler too
log view was changed accordingly
Save As button added
Clear Log (only the in-memory buffer and the view) button added, with confirmation dialog
Highlight text and button added
Verbosity toggling menu added
Debug mode check box removed (replaced by verbosity = Debug)
Replace #830