Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dovecot: no " in mailbox.name #34759

Merged
merged 1 commit into from Feb 9, 2018
Merged

nixos/dovecot: no " in mailbox.name #34759

merged 1 commit into from Feb 9, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

See #34629.

We might want to backport to 17.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @phdoerfler @FRidh

@andir
Copy link
Member

andir commented Feb 9, 2018

Sound like a reasonable thing to do. Might be worth following up with dovecot upstream anyway?

@andir andir merged commit 7ae9699 into NixOS:master Feb 9, 2018
@dotlambda
Copy link
Member Author

Do you mean updating the 17.09 package? I think we shouldn't update from 2.2.33.2 to 2.3.0.
2.2.33.2 is the newest release in the 2.2 branch so we should be fine.

@dotlambda dotlambda deleted the dovecot branch February 9, 2018 11:46
@andir
Copy link
Member

andir commented Feb 9, 2018

I did backport this to 17.09 and then realized that we can not use strMatching there yet. Do you have another solution? E.g. build another type

The issue is that the regex code isn't present on 17.09 per default.

@andir
Copy link
Member

andir commented Feb 9, 2018

I meant asking the upstream project how one would properly escape an "

@dotlambda
Copy link
Member Author

Well the other solution would be to use stringToCharacters and check for " using elem. But that's probably horribly inefficient.

I asked them about escaping on IRC.

@andir andir mentioned this pull request Feb 9, 2018
8 tasks
@FRidh
Copy link
Member

FRidh commented Feb 9, 2018

I did backport the "faulty" commit from in #34629, so it either needs to be fixed in 17.09 or reverted.

@dotlambda
Copy link
Member Author

It is not faulty. Mailbox names with quotes inside do lead to doveconf complaining about errors in the configuration file after and before that commit.
This PR would just make it impossible to specify a mailbox qith quotes in the name. So essentially, right now Dovecot is complaining whereas if this gets merged nixos-rebuild will complain about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants