Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dateparser: 0.6.0 -> 0.7.0 #34768

Merged
merged 1 commit into from Feb 9, 2018
Merged

pythonPackages.dateparser: 0.6.0 -> 0.7.0 #34768

merged 1 commit into from Feb 9, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 9, 2018 •
edited

Motivation for this change

YAML was replaced by ruamel: scrapinghub/dateparser@fee300c
Also did some further refactoring.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc @makefu

@dotlambda dotlambda requested a review from FRidh as a code owner February 9, 2018 16:45
@dotlambda dotlambda mentioned this pull request Feb 9, 2018
Merged
8 tasks
@dotlambda dotlambda mentioned this pull request Feb 9, 2018
Closed
FRidh
FRidh reviewed Feb 9, 2018
View reviewed changes
pkgs/development/python-modules/dateparser/default.nix Outdated
# install_requires
dateutil pytz regex tzlocal
# extra_requires
(if isPy3k then null else umalqurra)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ lib.optional isPy3k umalqurra

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that in the first place, but I want to somehow make clear it is an extra requirement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it be clearer this way? Simply stating that it is optional (extra_requires) is sufficient.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could think it is required for Python 2. But I'll change it anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it seems like umalqurra is now supported on Python 3. No need for lib.optional.

@dotlambda
Copy link
Member Author

I have successfully run nox-review. I believe this can be merged.

@makefu
Copy link
Contributor

makefu commented Feb 9, 2018

Thanks for your work!

@FRidh FRidh merged commit 75c5b8c into NixOS:master Feb 9, 2018
@dotlambda dotlambda deleted the dateparser branch February 9, 2018 19:43
@dotlambda
Copy link
Member Author

@makefu I hope to meet you at Shackspace on Wednesday

@makefu
Copy link
Contributor

makefu commented Feb 9, 2018

@dotlambda sure do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@makefu makefu makefu approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @makefu @FRidh @GrahamcOfBorg