Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.awesome-slugify: fix build #34764

Merged
merged 2 commits into from Feb 9, 2018
Merged

python.pkgs.awesome-slugify: fix build #34764

merged 2 commits into from Feb 9, 2018

Conversation

thorstenweber83
Copy link
Contributor

It broke because Unidecode went out of
its defined range (Unidecode>=0.04.14,<0.05)
with commit 57e9ed3

Motivation for this change

fix octoprint

Things done
  • [ x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@thorstenweber83
python.pkgs.awesome-slugify: fix build
1808043 
It broke because Unidecode went out of
its defined range (Unidecode>=0.04.14,<0.05)
with commit 57e9ed3
@dotlambda
Copy link
Member

Would you mind removing name from the expression while you're at it?

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.awesome-slugify python3.pkgs.awesome-slugify octoprint

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/tmp/nix-build-OctoPrint-1.3.5.drv-0/source/src/octoprint/server/__init__.py:14: ExtDeprecationWarning: Importing flask.ext.assets is deprecated, use flask_assets instead.
  from flask.ext.assets import Environment, Bundle
........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 552 tests in 26.250s

OK
/nix/store/1pwry2vwqps6bchpv591i6bs2mwk09v2-python2.7-awesome-slugify-1.6.5
/nix/store/d98zkj4zlz1ncyq9iwqplkzxhpbhd3jl-python3.6-awesome-slugify-1.6.5
/nix/store/26p8i2n14cy660f6aw22zyr8d9icqc0x-OctoPrint-1.3.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/build/source/src/octoprint/server/__init__.py:14: ExtDeprecationWarning: Importing flask.ext.assets is deprecated, use flask_assets instead.
  from flask.ext.assets import Environment, Bundle
........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 552 tests in 49.889s

OK
/nix/store/39zj4i568mshhb8wgcl2wm5f5k63bs2z-python2.7-awesome-slugify-1.6.5
/nix/store/f317yhx4apmc4z3z46nqryngbcx6kjva-python3.6-awesome-slugify-1.6.5
/nix/store/0hc7gmrrmj2f9y4kycxb9jizs783m3ky-OctoPrint-1.3.5

@Mic92 Mic92 merged commit 814a931 into NixOS:master Feb 9, 2018
thorstenweber83 added a commit to thorstenweber83/nixpkgs that referenced this pull request Feb 12, 2018
@thorstenweber83
python.pkgs.awesome-slugify: fix build (NixOS#34764)
751c850 
It broke because Unidecode went out of
its defined range (Unidecode>=0.04.14,<0.05)
with commit 57e9ed3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thorstenweber83 @dotlambda @GrahamcOfBorg @Mic92