Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asciidoctor: expose all the bins #34763

Merged
merged 1 commit into from Feb 9, 2018
Merged

asciidoctor: expose all the bins #34763

merged 1 commit into from Feb 9, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 9, 2018

Motivation for this change

asciidoctor has multiple binaries, expose them all to the user. Fixes #24293

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@zimbatm
asciidoctor: expose all the bins
6f56749 
asciidoctor has multiple binaries, expose them all to the user
@zimbatm
Copy link
Member Author

zimbatm commented Feb 9, 2018

@GrahamcOfBorg build asciidoctor

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


100 93228  100 93228    0     0   244k      0 --:--:-- --:--:-- --:--:--  244k


100  133k  100  133k    0     0   323k      0 --:--:-- --:--:-- --:--:--  323k


 63  536k   63  341k    0     0   632k      0 --:--:-- --:--:-- --:--:--  631k
100  536k  100  536k    0     0   880k      0 --:--:-- --:--:-- --:--:--  879k

building path(s) ‘/nix/store/njq4l1j5aznh7iar7v7hzx22b8pnvp8k-asciidoctor-1.5.6.1’
created 133 symlinks in user environment
building path(s) ‘/nix/store/azzhbmh6hpjyg7l3ksmvmr6kv96dcqcq-asciidoctor-1.5.6.1’
/nix/store/azzhbmh6hpjyg7l3ksmvmr6kv96dcqcq-asciidoctor-1.5.6.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

copying path '/nix/store/iskx886pys9ybv5rzhvhjh5n5m25j03h-ruby2.3.6-safe_yaml-1.0.4' from 'https://cache.nixos.org'...
copying path '/nix/store/l7iiv0xy4lnrkl861g3hgzrnfhz4hf5f-ruby2.3.6-slim-3.0.7' from 'https://cache.nixos.org'...
copying path '/nix/store/5hy0f39lk51i3plcq4hmc909hy7msmjy-ruby2.3.6-sprockets-3.7.1' from 'https://cache.nixos.org'...
copying path '/nix/store/dbjfjvhg284s40k8xxlajh2vwh7ag8bf-ruby2.3.6-thread_safe-0.3.5' from 'https://cache.nixos.org'...
copying path '/nix/store/0nw7zz5ak0z95k56hhhpivpf4fqhca8k-ruby2.3.6-tilt-2.0.6' from 'https://cache.nixos.org'...
copying path '/nix/store/34n2cw9nggsbdqz3ffmiq32ri23qdvn8-ruby2.3.6-treetop-1.5.3' from 'https://cache.nixos.org'...
building '/nix/store/9dxhy2i42s1wcprm5q7bn7p899bhpmv9-asciidoctor-1.5.6.1.drv'...
created 133 symlinks in user environment
building '/nix/store/fj208gmjbj1qh87kpzl5m90sdkfrsbf0-asciidoctor-1.5.6.1.drv'...
/nix/store/5zb1fbq13mnyzibiisy1mrlynjx2bq4a-asciidoctor-1.5.6.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

copying path '/nix/store/9xfa83fp5cxcgqqf310wcd0jd40idvqk-ruby2.3.6-sprockets-3.7.1' from 'https://cache.nixos.org'...
copying path '/nix/store/wv6987h4x47nsx1n320pbjg0h9fbbbys-ruby2.3.6-temple-0.7.7' from 'https://cache.nixos.org'...
copying path '/nix/store/z69rqzadhzl6lw1hr4abz1wrrlfkn5wm-ruby2.3.6-thread_safe-0.3.5' from 'https://cache.nixos.org'...
copying path '/nix/store/bbv2jv4436zx1zx8pgg9izghh30h859w-ruby2.3.6-tilt-2.0.6' from 'https://cache.nixos.org'...
copying path '/nix/store/5lsjaiijdlj8wshmf9l5v7aa3kwqjk0n-ruby2.3.6-treetop-1.5.3' from 'https://cache.nixos.org'...
copying path '/nix/store/b4yhygfvrk6mh384ax3gv1famgi8py7d-ruby2.3.6-ttfunk-1.4.0' from 'https://cache.nixos.org'...
building '/nix/store/x9z1cni359isqfylrl76a197avkqmy4k-asciidoctor-1.5.6.1.drv'...
created 133 symlinks in user environment
building '/nix/store/h6fxlxwashffhjnq6cbx0s4sxb1si4jz-asciidoctor-1.5.6.1.drv'...
/nix/store/z7shnwb7z7p4rjh7pn12fx5r1irwgjg0-asciidoctor-1.5.6.1

@zimbatm zimbatm mentioned this pull request Feb 9, 2018
Closed
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/azzhbmh6hpjyg7l3ksmvmr6kv96dcqcq-asciidoctor-1.5.6.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/z7shnwb7z7p4rjh7pn12fx5r1irwgjg0-asciidoctor-1.5.6.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/5zb1fbq13mnyzibiisy1mrlynjx2bq4a-asciidoctor-1.5.6.1

@Mic92 Mic92 merged commit 465d7c5 into NixOS:master Feb 9, 2018
@zimbatm zimbatm deleted the asciidoctor-pdf-fix branch February 9, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @GrahamcOfBorg @Mic92