Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flexget: mark as broken #34771

Merged
merged 1 commit into from Feb 9, 2018
Merged

flexget: mark as broken #34771

merged 1 commit into from Feb 9, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 9, 2018 •
edited

Motivation for this change

... I already had to fix flexget for last two nixos releases.

cc @domenkozar @tari

something fundamental has to change in packaging of flexget to prevent breakage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

something fundamental has to change in packaging of flexget to prevent breakage

i.e. the versions of the dependencies have to be pinned and someone has to actively maintain it.

See also #34589. Cc @Ma27

@Mic92
Copy link
Member Author

Mic92 commented Feb 9, 2018 •
edited

Yeah, but somebody has to care enough to do this actually for flexget. I already wasted too much time on flexget. And it constantly popups in reviews of python libraries.

@dotlambda
Copy link
Member

I know. I'm all for marking as broken.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Package ‘FlexGet-2.10.82’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/networking/flexget/default.nix:75 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘FlexGet-2.10.82’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/applications/networking/flexget/default.nix:75 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘FlexGet-2.10.82’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/networking/flexget/default.nix:75 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Ma27
Copy link
Member

Ma27 commented Feb 9, 2018

full ACK from my side. I had a look at it and tried to fix it, however I don't actively use it, so I decided to stop this for now and I think that marking this as broken is the best option for now.

@FRidh
Copy link
Member

FRidh commented Feb 9, 2018

I'm of the opinion we should not bother with these kind of applications until we approach a NixOS release.

Earlier today I was thinking of a way we could have a custom meta.broken that would print a message that this package needs to be fixed before a NixOS release.

@FRidh FRidh merged commit e44d763 into NixOS:master Feb 9, 2018
@FRidh
Copy link
Member

FRidh commented Feb 9, 2018

We can also make rules that we don't do any major updates in the Python package set during certain periods. E.g., only big updates every month. It would save a lot of work...

@FRidh FRidh mentioned this pull request Feb 9, 2018
Closed
@Mic92 Mic92 deleted the flexget branch February 10, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @dotlambda @GrahamcOfBorg @Ma27 @FRidh