Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gixy: 0.1.8 -> 0.1.9 #36286

Merged
merged 1 commit into from Mar 4, 2018
Merged

gixy: 0.1.8 -> 0.1.9 #36286

merged 1 commit into from Mar 4, 2018

Conversation

WilliButz
Copy link
Member

Motivation for this change

latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda requested changes Mar 4, 2018
View reviewed changes
pkgs/tools/admin/gixy/default.nix Outdated
@@ -2,7 +2,7 @@

python.pkgs.buildPythonApplication rec {
name = "gixy-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify pname instead.

pkgs/tools/admin/gixy/default.nix
@@ -11,7 +11,7 @@ python.pkgs.buildPythonApplication rec {
owner = "yandex";
repo = "gixy";
rev = "v${version}";
sha256 = "0dg8j8pqlzdvmyfkphrizfqzggr64npb9mnm1dcwm6c3z6k2b0ii";
sha256 = "11aps8a8xg1nlw36jgrmnaf38imfz2rj67wnlalrrsqb616xipcv";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to use fetchPypi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotlambda I did neither know about that nor think of it when I packaged this :)
Let me take a look.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's for the hint, it is also available from pypi 👍

@dotlambda
Copy link
Member

@GrahamcOfBorg build gixy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

reading manifest file 'gixy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'gixy.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.035s

OK
/nix/store/93m32yh4ah9sn0bvm5k4xc5gndbvwffd-gixy-0.1.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

reading manifest file 'gixy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'gixy.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.117s

OK
/nix/store/mv8jlb2cs40yfr8scj7vri6dr1vibl7v-gixy-0.1.9

@dotlambda
Copy link
Member

Ran 0 tests in 0.035s

Please run the tests by setting something like

checkPhase = ''
  nosetests
'';

However, I think we'll have to go back to using fetchFromGitHub because the tests folder seems to be missing from the PyPI tarball.

@WilliButz
Copy link
Member Author

@dotlambda yeah the tests are are missing in the pypi source, however building it using the github source, tests are run automatically. Would you still prefer to specify the checkPhase manually?

----------------------------------------------------------------------
Ran 292 tests in 0.920s

OK

@dotlambda
Copy link
Member

dotlambda commented Mar 4, 2018 •
edited

Ah no, then thre's no need to specify checkPhase. But please add a comment why you're using GitHub.

@dotlambda
Copy link
Member

@GrahamcOfBorg build gixy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

tests.plugins.test_simply.test_from_config('ssrf', '/tmp/nix-build-gixy-0.1.9.drv-0/source/tests/plugins/simply/ssrf/not_host_var_fp.conf', {u'severity': u'HIGH'}) ... ok
tests.plugins.test_simply.test_from_config('valid_referers', '/tmp/nix-build-gixy-0.1.9.drv-0/source/tests/plugins/simply/valid_referers/none_first.conf', {u'severity': u'HIGH'}) ... ok
tests.plugins.test_simply.test_from_config('valid_referers', '/tmp/nix-build-gixy-0.1.9.drv-0/source/tests/plugins/simply/valid_referers/none_middle.conf', {u'severity': u'HIGH'}) ... ok
tests.plugins.test_simply.test_from_config('valid_referers', '/tmp/nix-build-gixy-0.1.9.drv-0/source/tests/plugins/simply/valid_referers/wo_none_fp.conf', {u'severity': u'HIGH'}) ... ok
tests.plugins.test_simply.test_from_config('valid_referers', '/tmp/nix-build-gixy-0.1.9.drv-0/source/tests/plugins/simply/valid_referers/none_last.conf', {u'severity': u'HIGH'}) ... ok

----------------------------------------------------------------------
Ran 292 tests in 0.962s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

tests.plugins.test_simply.test_from_config('add_header_multiline', '/build/source/tests/plugins/simply/add_header_multiline/more_set_headers_fp.conf', {u'severity': u'LOW'}) ... ok
tests.plugins.test_simply.test_from_config('add_header_multiline', '/build/source/tests/plugins/simply/add_header_multiline/more_set_headers.conf', {u'severity': u'LOW'}) ... ok
tests.plugins.test_simply.test_from_config('add_header_multiline', '/build/source/tests/plugins/simply/add_header_multiline/add_header_fp.conf', {u'severity': u'LOW'}) ... ok
tests.plugins.test_simply.test_from_config('add_header_multiline', '/build/source/tests/plugins/simply/add_header_multiline/add_header.conf', {u'severity': u'LOW'}) ... ok

----------------------------------------------------------------------
Ran 292 tests in 5.403s

OK
/nix/store/g2imjxccrk1an3w4278b6m4zq1bmv1xc-gixy-0.1.9

@dotlambda dotlambda merged commit a381e98 into NixOS:master Mar 4, 2018
@dotlambda
Copy link
Member

Thanks a lot!

@WilliButz WilliButz deleted the update-gixy branch March 4, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @dotlambda @GrahamcOfBorg