keepassxc: enable ssh agent sockets #36307

Mic92 · 2018-03-04T19:56:30Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-03-04T19:57:32Z

I am mainly interested in macOS:

@GrahamcOfBorg build keepassx-community

GrahamcOfBorg · 2018-03-04T19:59:41Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/9avjr40zgds5rycm2ndw9imrfpkb3vga-CF-osx-10.10.5-private/Library/Frameworks/CoreFoundation.framework/Headers/CFUserNotification.h:123:78: error: use of old-style cast [-Werror,-Wold-style-cast]
CF_INLINE CFOptionFlags CFUserNotificationPopUpSelection(CFIndex n) {return ((CFOptionFlags)(n << 24));}
                                                                             ^              ~~~~~~~~~
11 errors generated.
make[2]: *** [src/CMakeFiles/keepassx_core.dir/build.make:519: src/CMakeFiles/keepassx_core.dir/core/ScreenLockListenerPrivate.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:197: src/CMakeFiles/keepassx_core.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/bdzif384690l72s636hp08pkix2a96db-keepassxc-2.3.0.drv' failed with exit code 2
error: build of '/nix/store/bdzif384690l72s636hp08pkix2a96db-keepassxc-2.3.0.drv' failed

GrahamcOfBorg · 2018-03-04T20:00:12Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/bin/keepassxc-cli
shrinking /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/bin/keepassxc
shrinking /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/lib/keepassxc/libkeepassx-autotype-xcb.so
gzipping man pages under /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/lib  /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/bin 
patching script interpreter paths in /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0
checking for references to /tmp/nix-build-keepassxc-2.3.0.drv-0 in /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0...
postPatchMkspecs
postPatchMkspecs

Mic92 · 2018-03-04T20:02:01Z

@LnL7 so clang complains about os x standard includes?

GrahamcOfBorg · 2018-03-04T20:04:37Z

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0

GrahamcOfBorg · 2018-03-04T20:04:37Z

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0/bin/keepassxc-cli
shrinking /nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0/bin/keepassxc-proxy
shrinking /nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0/bin/keepassxc
gzipping man pages under /nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0/lib  /nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0/bin
patching script interpreter paths in /nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0
checking for references to /build in /nix/store/ldp9djck0isa889kic4m59v3fa9hi4z4-keepassxc-2.3.0...
postPatchMkspecs
postPatchMkspecs

GrahamcOfBorg · 2018-03-04T20:07:43Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

                                                                              ^              ~~~~~~~~~~~~~~~~~
/nix/store/9avjr40zgds5rycm2ndw9imrfpkb3vga-CF-osx-10.10.5-private/Library/Frameworks/CoreFoundation.framework/Headers/CFUserNotification.h:123:78: error: use of old-style cast [-Werror,-Wold-style-cast]
CF_INLINE CFOptionFlags CFUserNotificationPopUpSelection(CFIndex n) {return ((CFOptionFlags)(n << 24));}
                                                                             ^              ~~~~~~~~~
11 errors generated.
make[2]: *** [src/CMakeFiles/keepassx_core.dir/build.make:519: src/CMakeFiles/keepassx_core.dir/core/ScreenLockListenerPrivate.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:197: src/CMakeFiles/keepassx_core.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/6syn4nlzb1n0jvsrbrs1xs57r69mskjr-keepassxc-2.3.0.drv' failed with exit code 2
error: build of '/nix/store/6syn4nlzb1n0jvsrbrs1xs57r69mskjr-keepassxc-2.3.0.drv' failed

GrahamcOfBorg · 2018-03-04T20:12:58Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/bin/keepassxc
shrinking /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/bin/keepassxc-proxy
shrinking /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/lib/keepassxc/libkeepassx-autotype-xcb.so
gzipping man pages under /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/lib  /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0/bin 
patching script interpreter paths in /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0
checking for references to /tmp/nix-build-keepassxc-2.3.0.drv-0 in /nix/store/vrjh4h32mw8ffnjx5kgy6w3k08gwg1gr-keepassxc-2.3.0...
postPatchMkspecs
postPatchMkspecs

LnL7 · 2018-03-04T20:37:52Z

@Mic92 that's cf-private

Clang is generally more pedantic about things compared to gcc, I usually add something like this.

{
  NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.cc.isClang "-Wno-old-style-cast";
}

Mic92 · 2018-03-04T20:51:37Z

@GrahamcOfBorg build keepassx-community

GrahamcOfBorg · 2018-03-04T20:53:40Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/9avjr40zgds5rycm2ndw9imrfpkb3vga-CF-osx-10.10.5-private/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:363:5: error: '__LLP64__' is not defined, evaluates to 0 [-Werror,-Wundef]
#if __LLP64__
    ^
3 errors generated.
make[2]: *** [src/CMakeFiles/keepassx_core.dir/build.make:519: src/CMakeFiles/keepassx_core.dir/core/ScreenLockListenerPrivate.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:197: src/CMakeFiles/keepassx_core.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/cvvkpa96znwpjljf8pszvfqw8ar04cda-keepassxc-2.3.0.drv' failed with exit code 2
error: build of '/nix/store/cvvkpa96znwpjljf8pszvfqw8ar04cda-keepassxc-2.3.0.drv' failed

GrahamcOfBorg · 2018-03-04T20:54:04Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0/bin/keepassxc-cli
shrinking /nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0/bin/keepassxc
shrinking /nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0/lib/keepassxc/libkeepassx-autotype-xcb.so
gzipping man pages under /nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0/lib  /nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0/bin 
patching script interpreter paths in /nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0
checking for references to /tmp/nix-build-keepassxc-2.3.0.drv-0 in /nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0...
postPatchMkspecs
postPatchMkspecs

GrahamcOfBorg · 2018-03-04T20:58:39Z

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0/bin/keepassxc-cli
shrinking /nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0/bin/keepassxc-proxy
shrinking /nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0/bin/keepassxc
gzipping man pages under /nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0/lib  /nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0/bin
patching script interpreter paths in /nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0
checking for references to /build in /nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0...
postPatchMkspecs
postPatchMkspecs

Mic92 · 2018-03-04T21:01:20Z

Seem like some other header is missing:

/nix/store/9avjr40zgds5rycm2ndw9imrfpkb3vga-CF-osx-10.10.5-private/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:363:5: error: '__LLP64__' is not defined, evaluates to 0 [-Werror,-Wundef]

GrahamcOfBorg · 2018-03-04T21:18:45Z

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/hbrsnv9r13hngd0hc0s6ag3zxjfxlacx-keepassxc-2.3.0

GrahamcOfBorg · 2018-03-04T21:19:00Z

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/l8ciizcv8xwmp6yvch85pf40v2bxxj7y-keepassxc-2.3.0

GrahamcOfBorg · 2018-03-04T21:20:28Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

#if __LLP64__
    ^
[ 34%] Building CXX object src/CMakeFiles/keepassx_core.dir/core/Translator.cpp.o
3 errors generated.
make[2]: *** [src/CMakeFiles/keepassx_core.dir/build.make:519: src/CMakeFiles/keepassx_core.dir/core/ScreenLockListenerPrivate.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:197: src/CMakeFiles/keepassx_core.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/cvvkpa96znwpjljf8pszvfqw8ar04cda-keepassxc-2.3.0.drv' failed with exit code 2
error: build of '/nix/store/cvvkpa96znwpjljf8pszvfqw8ar04cda-keepassxc-2.3.0.drv' failed

Mic92 · 2018-03-05T13:54:54Z

I have no idea how to fix this.

keepassxc: enable ssh agent sockets

674c8ca

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 4, 2018

keepassxc: hopefully fix darwin

5bb9c36

Mic92 merged commit 9b7d93e into NixOS:master Mar 5, 2018

Mic92 deleted the keepassxc branch March 5, 2018 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keepassxc: enable ssh agent sockets #36307

keepassxc: enable ssh agent sockets #36307

Mic92 commented Mar 4, 2018 •

edited

Mic92 commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

Mic92 commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

LnL7 commented Mar 4, 2018

Mic92 commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

Mic92 commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

Mic92 commented Mar 5, 2018

keepassxc: enable ssh agent sockets #36307

keepassxc: enable ssh agent sockets #36307

Conversation

Mic92 commented Mar 4, 2018 • edited

Motivation for this change

Things done

Mic92 commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

Mic92 commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

LnL7 commented Mar 4, 2018

Mic92 commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

Mic92 commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

GrahamcOfBorg commented Mar 4, 2018

Mic92 commented Mar 5, 2018

Mic92 commented Mar 4, 2018 •

edited