Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/tests: Add check-eval.nix to run simple tests. #36287

Merged
merged 1 commit into from Sep 16, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 4, 2018

This can be used by evaluation-only tools to validate tests are still
working.

This can be used by evaluation-only tools to validate tests are still
working.
@shlevy
Copy link
Member Author

shlevy commented Mar 7, 2018

@grahamc ping

@shlevy
Copy link
Member Author

shlevy commented Mar 16, 2018

@grahamc Thoughts on this? I think it would be nice to add to ofborg.

@grahamc
Copy link
Member

grahamc commented Mar 16, 2018

Sorry for the delay! I committed "nixpkgs email bankruptcy" a few days ago, and only recently found a nice way to handle it all.

This looks like a good idea. I wonder how you came to the list of misc and systems tests. What about all the other files?

I might propose cleaning up this directory and-or even making the tests automatically discoverable, like:

$ nix-instantiate ./lib -A _tests

@shlevy
Copy link
Member Author

shlevy commented Mar 16, 2018

This list came from release.nix and removing the tests that require a build. modules.sh does some fairly intensive stuff outside of the "only eval by default" model of ofborg. Hydra should still do the full testsuite though.

Any thoughts on specific cleanup, given that not all of our tests are eval-only?

@shlevy
Copy link
Member Author

shlevy commented Apr 1, 2018

@grahamc ping

@shlevy
Copy link
Member Author

shlevy commented Sep 6, 2018

@grahamc ?

@grahamc grahamc merged commit 4c7f071 into NixOS:master Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants