Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Method#=== that invokes #call #5079

Merged
merged 1 commit into from Mar 20, 2018
Merged

Add Method#=== that invokes #call #5079

merged 1 commit into from Mar 20, 2018

Conversation

nomadium
Copy link
Contributor

@nomadium nomadium commented Mar 4, 2018

Hi folks,

This is another feature targeting Ruby 2.5 [1]: Add Method#=== that invokes #call (feature #14142).

The associated MRI test to the feature work as expected:

  def test_eqq
    assert_operator(0.method(:<), :===, 5)
    assert_not_operator(0.method(:<), :===, -5)
  end
miguel@alice:~/jruby$ PATH=$PWD/bin:$PATH jruby test/mri/runner.rb -v --color=never --tty=no --excludes=test/mri/excludes -q -n test_eqq -- ruby/test_method.rb
Run options: -v --color=never --tty=no --excludes=test/mri/excludes -q -n test_eqq --

# Running tests:

[1/1] TestMethod#test_eqq = 0.02 s
Finished tests in 0.260273s, 3.8421 tests/s, 15.3685 assertions/s.
1 tests, 4 assertions, 0 failures, 0 errors, 0 skips

ruby -v: jruby 9.3.0.0-SNAPSHOT (2.5.0) 2018-03-04 96b264b Java HotSpot(TM) 64-Bit Server VM 25.102-b14 on 1.8.0_102-b14 +jit [darwin-x86_64]

Thanks for your review and feedback.

  1. Ruby 2.5 Support #4876

@nomadium
Add Method#=== that invokes #call
d54139a 
For more information, please see feature #14142.
@nomadium nomadium mentioned this pull request Mar 20, 2018
Closed
75 tasks
@kares kares added this to the JRuby 9.3.0.0 milestone Mar 20, 2018
@kares kares merged commit 804fe00 into jruby:ruby-2.5 Mar 20, 2018
@nomadium nomadium deleted the add-method-eqq branch March 20, 2018 08:33
@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core ruby 2.5
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nomadium @enebo @kares