Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel-headers: fix asm symlinks #36303

Closed
wants to merge 1 commit into from
Closed

kernel-headers: fix asm symlinks #36303

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 4, 2018

We no longer set "platform", so the code referring to it
did the wrong thing.

Happened to notice that we created an "asm-" symlink.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill mentioned this pull request Mar 4, 2018
Closed
8 tasks
@dezgeg
Copy link
Contributor

dezgeg commented Mar 4, 2018

Did you notice anything broken? Maybe nothing actually needs this?

@dtzWill
Copy link
Member Author

dtzWill commented Mar 4, 2018

Haven't noticed anything broken, but without knowing/exploring why this was done originally seemed best to fix it :).

If we're sure it's not useful we can remove this entirely. Maybe it only helps with broken code? Dunno.

@dezgeg
Copy link
Contributor

dezgeg commented Mar 4, 2018

Well, git shows:

commit 539239d66d55ed7326f5af109d4788a81697b191
Author: Eelco Dolstra <eelco.dolstra@logicblox.com>
Date:   Wed Feb 18 14:53:14 2009 +0000

    * KVM 84.  CIFS/Samba performance still broken.
    * Kernel headers: KVM expects a include/linux/asm-x86 symlink, so
      provide it.
    
    svn path=/nixpkgs/trunk/; revision=14113

include/linux/asm-86 got removed in 2.6.28 almost ten years ago. I doubt anything needs it anymore :)

@dtzWill
Copy link
Member Author

dtzWill commented Mar 4, 2018

Do we need the other one, asm-x86_64 etc that's created as well? Or we're they both introduced with that commit?

@dezgeg
Copy link
Contributor

dezgeg commented Mar 4, 2018 •
edited

Seems to be even older stuff, that directory got removed in Linux 2.6.24. In nixpkgs that seemed to be needed for the out-of-tree (back then) KVM like was mentioned the above commit.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 6, 2018

Okay so looks like the answer is dropping this fixup entirely! I'll hopefully submit a PR for that soon but feel free if I take too long, got a lot on my plate :3.

@dtzWill dtzWill closed this Mar 6, 2018
@dtzWill dtzWill mentioned this pull request Mar 6, 2018
Merged
8 tasks
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Mar 6, 2018
@dtzWill
kernel-headers: remove deprecated and broken asm symlink fixups
3a40b33 
Discussion:
NixOS#36303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @dezgeg @fpletz @GrahamcOfBorg