openresty: 1.9.3.1 -> 1.13.6.1 #36289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build openresty |
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Mic92
reviewed
Mar 4, 2018
| { stdenv, fetchurl, fetchgit, openssl, zlib, pcre, libxml2, libxslt, gd, geoip | ||
| , perl }: | ||
| { stdenv, fetchurl, fetchgit, openssl, zlib, pcre, postgresql, libxml2, libxslt, | ||
| gd, geoip, perl }: | ||
|
|
||
| assert stdenv.isLinux; |
There was a problem hiding this comment.
This line can be removed. meta.platforms is enough.
There was a problem hiding this comment.
Thanks for review. Removed.
|
Package should also build on darwin, I've removed linux restriction. |
|
@GrahamcOfBorg build openresty |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Mic92
reviewed
Mar 4, 2018
| }; | ||
|
|
||
| buildInputs = [ openssl zlib pcre libxml2 libxslt gd geoip perl ]; | ||
| nativeBuildInputs = [ openssl zlib pcre libxml2 libxslt gd geoip postgresql ]; | ||
| buildInputs = [ perl ]; |
There was a problem hiding this comment.
Is it possible that you mixed up nativeBuildInputs and buildInputs? Libraries should be be in buildInputs and native tools (the architecture of the host compiling the package) should be in nativeBuildInputs.
There was a problem hiding this comment.
You are right, nativeBuildInputs should be in buildInputs, they are needed also in runtime. Thanks for fixup.
|
@GrahamcOfBorg build openresty |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
GrahamcOfBorg
added
8.has: package (new)
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
labels
|
Here we go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bump, cc @thoughtpolice
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)