nixos/initrd-network: add udhcpc.extraArgs option #36305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to fix issues where udhcpc times out before acquiring a lease. For example of these issues, see: https://bugs.alpinelinux.org/issues/3105#note-8 Signed-off-by: Dino A. Dai Zovi <ddz@theta44.org>
Mic92
reviewed
Mar 4, 2018
| @@ -47,6 +49,16 @@ in | |||
| ''; | |||
| }; | |||
|
|
|||
| boot.initrd.network.udhcpc.extraArgs = mkOption { | |||
| default = ""; | |||
There was a problem hiding this comment.
Empty list maybe? Otherwise the type is not correct (also I don't know if default values are type checked).
There was a problem hiding this comment.
Good catch, thank you. Addressed in 4f0596a.
Signed-off-by: Dino A. Dai Zovi <ddz@theta44.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This can be used to fix issues where udhcpc times out before
acquiring a lease. For example of these issues, see:
https://bugs.alpinelinux.org/issues/3105#note-8
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)