Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: monero-project/monero
base: 421ab3119ce8
Choose a base ref
...
head repository: monero-project/monero
compare: c7ace5fa3d41
Choose a head ref
  • 2 commits
  • 53 files changed
  • 2 contributors

Commits on Mar 4, 2018

  1. Code modifications to integrate Ledger HW device into monero-wallet-cli.

    The basic approach it to delegate all sensitive data (master key, secret
    ephemeral key, key derivation, ....) and related operations to the device.
    As device has low memory, it does not keep itself the values
    (except for view/spend keys) but once computed there are encrypted (with AES
    are equivalent) and return back to monero-wallet-cli. When they need to be
    manipulated by the device, they are decrypted on receive.
    
    Moreover, using the client for storing the value in encrypted form limits
    the modification in the client code. Those values are transfered from one
    C-structure to another one as previously.
    
    The code modification has been done with the wishes to be open to any
    other hardware wallet. To achieve that a C++ class hw::Device has been
    introduced. Two initial implementations are provided: the "default", which
    remaps all calls to initial Monero code, and  the "Ledger", which delegates
    all calls to Ledger device.
    cslashm committed Mar 4, 2018
    Copy the full SHA
    e745c1e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3303

    e745c1e Code modifications to integrate Ledger HW device into monero-wallet-cli. (cslashm)
    fluffypony committed Mar 4, 2018
    Copy the full SHA
    c7ace5f View commit details
    Browse the repository at this point in the history