New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite: Raising max variable number and max expr depth values #36293
Conversation
This factors out the functionality in nixos-install for running a command inside a NixOS installation (nixos-install --chroot).
The use of Nix 2.0 significantly simplifies the installer, since we can just pass a different store URI (--store /mnt) - it's no longer needed to set up a chroot environment for the build, and to bootstrap Nix into the chroot. Also, commands that need to run in the installation (namely boot loader installation and setting a root password) are now executed using nixos-enter. This also removes the need for nixos-prepare-root since any required initialisation is done by Nix or by the activation script.
It requires the existence of /proc.
The activation script already does this.
...so it appears in a new installation before rebooting the system.
the new version brings a new panel in IPsec settings which allows to reenable old algorithms for IPsec phases 1/2 (dropped in recent libreswan/strongswan etc). Also updates the homepage with the new one.
l2tp saves its secrets into /etc/ipsec.d but strongswan would not read them. l2tp checks for /etc/ipsec.secrets includes /etc/ipsec.d and if not tries to write into it. Solution: Have the strongswan module create /etc/ipsec.d and /etc/ipsec.secrets when networkmanager_l2tp is installed. Include /etc/ipsec.secrets in /nix/store/hash-strongswan/etc/ipsec.secrets so that it can find l2tp secrets. Also when the ppp 'nopeerdns' option is used, the DNS resolver tries to write into an alternate file /etc/ppp/resolv.conf. This fails when /etc/ppp does not exist so the module creates it by default.
The boot test now runs "nix verify" to ensure that all hashes are correct.
E.g. nixos-install --root /tmp/mnt/ --no-bootloader --no-root-passwd now works for non-root users.
This is already provided by devtmpfs.
Of course, you'll get a bunch of warnings from the activation script: $ nixos-enter --root /tmp/mnt/ setting up /etc... mount: /dev: permission denied. mount: /dev/pts: permission denied. mount: /dev/shm: permission denied. mount: /sys: permission denied. /nix/var/nix/profiles/system/activate: line 74: /proc/sys/kernel/modprobe: Permission denied chown: changing ownership of '/run/wrappers/wrappers.0pKlU8JsvV/dbus-daemon-launch-helper': Invalid argument NOTE: Under Linux, effective file capabilities must either be empty, or exactly match the union of selected permitted and inheritable bits. Failed to set capabilities on file `/run/wrappers/wrappers.0pKlU8JsvV/ping' (Operation not permitted) chown: changing ownership of '/run/wrappers/wrappers.0pKlU8JsvV/unix_chkpwd': Invalid argument [root@nixos:/]#
This is useful in tests where we don't have network access. Passing --substituters "" prevents wasting time by checking cache.nixos.org.
Since nixos-install doesn't require any special privileges anymore, this Just Works. No more need for fakeroot / nixos-prepare-root.
This is no longer needed thanks to Nix 2.0 magic.
protocol really is a "buildPythonApplication" rather than a buildPythonPackage".
gixy: 0.1.8 -> 0.1.9
riot-web: make package configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should go to the staging branch first though.
What do you mean by staging branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other distributions like Debian are doing the same.
@sjau We have a branch called |
And how to do that? |
There is an edit button next to the pull request title. I have pushed the commit now to staging myself and this pull request will be closed automatically once the commit is merged back into staging. |
No idea why now errors appear.... |
Why did suddenly so many other things come in here? It was just a simple PR with some SQLite compile settings altered.... |
you changed the base without rebasing locally. This means you attempt, you pushed all commits from master to staging. |
fixes NixOS#36293 (cherry picked from commit fe5f012)
Motivation for this change
I've been having troubles with Flexget and it seems (one of) the problems is that SQLite does have a rather low number of max variables. Having a look at Arch, they have a significantly higher value for maximum variables. Default is 1000 and in arch they have 250 000: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/sqlite#n36
At the same time it also seems a good idea to also raise the max expr depth to the same value as Arch.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)