Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xen: add v 4.10 #36292

Merged
merged 3 commits into from Mar 7, 2018
Merged

xen: add v 4.10 #36292

merged 3 commits into from Mar 7, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 4, 2018

Motivation for this change

Would like to experiment with latest xen version (in particular, try to enable xen-uefi boot in NixOS - which appears to require xen >= 4.9).
This change only adds xen 4.10. It does not modify the other versions (4.5 and 4.8) and leaves the default at 4.5 to prevent breaking existing installations.

Current Status
  • xen_4_10-vanilla, -light and -slim build
  • hypervisor and dom0 boot in a vm
  • oxenstored fails to start (caused by missing config file)
Things done
  • fix broken version check in generic.nix (previous string comparison broke with 4.10)
  • bump versions
  • add relevant xsa patches for 4.10
  • fix broken build of xen_4_10-vanilla
Things to do
  • test, test, test

/CC xen maintainers: @edolstra @oxij @tstrobel

@oxij
Copy link
Member

oxij commented Mar 4, 2018 via email

@xeji
Copy link
Contributor Author

xeji commented Mar 4, 2018

I agree that 4.5 should be deprecated since security support ended in January.

@xeji
Copy link
Contributor Author

xeji commented Mar 5, 2018

now all 3 versions (-vanilla, -slim, -light) build. Still needs testing.

@xeji
Copy link
Contributor Author

xeji commented Mar 5, 2018

@oxij regarding xen 4.8, I believe this will fix the gcc7 build error: https://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=f49fa658b53580cf2ad354d2bf1796766cc11222

@oxij
Copy link
Member

oxij commented Mar 5, 2018 via email

@xeji
Copy link
Contributor Author

xeji commented Mar 5, 2018

sure, will do and let you know/

@xeji
Copy link
Contributor Author

xeji commented Mar 5, 2018

4.8: we're on the right track. Patch fixed previous error but no a similar error occurs in another place. I'll keep picking patches and open a separate PR when it works
Edit: 4.8 builds now, see #36353

@xeji
Copy link
Contributor Author

xeji commented Mar 7, 2018

rebased on master

@xeji
Copy link
Contributor Author

xeji commented Mar 7, 2018

4.10 works now. Tested in a VM with no obvious problems. Could use some more testing (maybe on real hardware) to make sure it's ready to merge.

@7c6f434c
Copy link
Member

7c6f434c commented Mar 7, 2018

From a glance, it looks like it doesn't change 4.8. If it is a pure addition, maybe it should be just merged? Or maybe @oxij wants to test it on real hardware…

@oxij
Copy link
Member

oxij commented Mar 7, 2018 via email

@xeji
Copy link
Contributor Author

xeji commented Mar 7, 2018

Sounds good. I'll clean up the commits first, then we can merge.

xeji added 3 commits March 7, 2018 22:37
string compare breaks with xen 4.10 (because "4.10" < "4.8")
this is required for oxenstored to start
@xeji xeji changed the title [WIP] xen: add v 4.10 xen: add v 4.10 Mar 7, 2018
@xeji
Copy link
Contributor Author

xeji commented Mar 7, 2018

Ready to merge.

@7c6f434c 7c6f434c merged commit 5a95fe2 into NixOS:master Mar 7, 2018
@oxij
Copy link
Member

oxij commented Mar 7, 2018 via email

@xeji xeji deleted the xen-4-10 branch March 7, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants