Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module#attr, attr_accessor, attr_reader, attr_writer are now public #5043

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Module#attr, attr_accessor, attr_reader, attr_writer are now public #5043

merged 2 commits into from
Feb 15, 2018

Conversation

nomadium
Copy link
Contributor

Hi folks,

This is another feature targeting Ruby 2.5 [1]:

  • Module#attr, attr_accessor, attr_reader, attr_writer are now public (feature #14132).

Note: The tests are copied from MRI.

Thanks for your review and feedback.

  1. Ruby 2.5 Support #4876

@nomadium
Add MRI test for Module new public methods
1bb4456 
New public methods on Module class:

  - attr
  - attr_accessor
  - attr_reader
  - attr_writer
@nomadium
Module#attr, attr_accessor, attr_reader, attr_writer are now public
62c5de5 
For more information, please see feature #14132.
@enebo enebo added this to the JRuby 9.3.0.0 milestone Feb 15, 2018
@enebo enebo merged commit 7901f47 into jruby:ruby-2.5 Feb 15, 2018
@nomadium nomadium deleted the module-attr-methods-are-now-public branch February 15, 2018 19:03
@enebo enebo modified the milestones: JRuby 9.3.0.0, JRuby 9.2.0.0 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nomadium @enebo