xcpc: init at version 20070122 #34965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lheckemann
reviewed
Feb 15, 2018
| sha256 = "12yv56blm49qmshpk4mgc802bs51wv2ra87hmcbf2wxma39c45fy"; | ||
| }; | ||
|
|
||
| patchPhase = "substituteInPlace cap32.cfg --replace /usr/local $out"; |
There was a problem hiding this comment.
Suggest using prePatch or postPatch instead. Replacing patchPhase prevents addition of patches while overriding like caprice32.overrideAttrs (o: {patches = [./foo.patch];})
lheckemann
reviewed
Feb 15, 2018
| @@ -0,0 +1,22 @@ | |||
| { stdenv, fetchurl }: | |||
|
|
|||
| with stdenv.lib; | |||
There was a problem hiding this comment.
Probably move this to meta, since you're not using any of stdenv.lib elsewhere and it may cause confusion
|
@GrahamcOfBorg build caprice32 xcpc |
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
lheckemann
reviewed
Feb 15, 2018
| stdenv.mkDerivation rec { | ||
|
|
||
| pname = "caprice32"; | ||
| version = "02102017"; |
There was a problem hiding this comment.
20170210 so that version ordering works, maybe add dashes for clarity
|
Overall LGTM. Please split into multiple commits according to CONTRIBUTING.md though |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
joachifm
reviewed
Feb 16, 2018
| }; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "a library for accessing discs and disc image files"; |
There was a problem hiding this comment.
Please capitalize the description
joachifm
reviewed
Feb 16, 2018
| description = "a library for accessing discs and disc image files"; | ||
| homepage = http://www.seasip.info/Unix/LibDsk/ ; | ||
| license = licenses.gpl2; | ||
| maintainers = [ maintainers.genesis ]; |
There was a problem hiding this comment.
It's generally preferred to use a maintainer handle that matches the github handle.
There was a problem hiding this comment.
i will change maintainers in a separate PR for all my derivation.
|
i'd wake up here to close PR. 20070122 is official name of this release btw. |
bignaux
requested review from
Ericson2314,
FRidh,
nbp,
orivej,
peti,
ttuegel and
zimbatm
as code owners
added 2 commits
February 27, 2018 19:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
libdsk : new , dep for xcpc
xcpc + caprice32 , small derivations, i put all this in same commit, should be easy to review.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)