New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and introduce Godot and godot_headers #34971
Conversation
{ stdenv, fetchFromGitHub }: | ||
stdenv.mkDerivation rec { | ||
name = "godot_headers"; | ||
version = "51bca3bf5d917341f3e15076c5a9191f8a5118ae"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a valid version string; see e.g. parseDrvName
. It's common to use the rev date for unreleased versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
fdfa101
to
87f80e2
Compare
I'm not sure why EDIT: figured out; fixed. |
Bump! I build this a lot — would be nice to have it cached. |
@GrahamcOfBorg build godot godot_headers |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
It might be supported on Darwin, but I haven't been able to test. |
Is something wrong with this PR? |
@Twey Currently the PR can't be merged, most likely due to 1bc1909. You should rebase your changes over this commit, I think :) Also, ofborg reported a failure on aarch64-linux. Unfortunately full logs have since been deleted (they're deleted 7 days after build completion), so there's no easy way to know what exactly went wrong. So, as I guess upstream godot has no support of aarch64 (from https://godot.readthedocs.io/en/latest/development/compiling/introduction_to_the_buildsystem.html#bits), so after having checked godot 2.1.4 didn't build on aarch64 either you could just change the |
Thanks a lot! How's this? :) |
Success on aarch64-linux (full log) Attempted: godot_headers The following builds were skipped because they don't evaluate on aarch64-linux: godot Partial log (click to expand)
|
@Twey Guess you'll have to update your patches, likely due to the switch to 3.0.2 ;) |
I was pretty tired when I pushed that commit… |
Thanks! Just two little things before retriggering a rebuild:
|
I'm not sure — I was modifying the old one, so I made minimal changes. I'll give it a test. |
Seems it works! |
@GrahamcOfBorg build godot godot_headers |
Is this a success output? |
Turns out I didn't have access to ofborg yet, so when NixOS/ofborg#140 is deployed I'll be able to trigger the build, sorry! |
@GrahamcOfBorg build godot godot_headers |
Success on aarch64-linux (full log) Attempted: godot_headers The following builds were skipped because they don't evaluate on aarch64-linux: godot Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: godot, godot_headers Partial log (click to expand)
|
I think this is good to merge, modulo x86_64 for which I'm not accredited to trigger builds, due to the lack of sandboxing :) cc @joachifm, as you had started reviewing it a few weeks ago :) |
There are three different pull requests for this now… is there some reason they're not being merged? |
OK, I tested execution of the binary and it looks sane on all accounts to me. I don't know much else about Godot, but I see no glaring issues here, so here goes. |
@Twey what's the point of pkgs/development/tools/godot/dont_clobber_environment.patch? |
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)