rand() -> random(), since we use srandom(). #1955
Merged
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rand() requires we call srand() instead,
but might as well use random().
As-is, all threads will have the same seed and
(in some cases) quickly encounter problems when
they generate the same temporary link names in the same order.
Looking at the glibc source, it appears to implement
rand() using random() which is why this didn't cause
bigger problems previously.
Note that "random()" does return "long int" instead
of the "int" returned by "rand()" but that seems okay:
either they're the same size or the larger type
results in slightly longer names for our temporary
links bringing with it a corresponding reduction
in chance of collision between threads.