Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0b455cec9309
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b5cf1d2e5079
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Mar 6, 2018

  1. Copy the full SHA
    76bc1d3 View commit details

Commits on Mar 7, 2018

  1. Merge pull request #36399 from obsidiansystems/no-stdenv-cross-adapter

    guile: Fix cross more, including 1.8
    Ericson2314 authored Mar 7, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    b5cf1d2 View commit details
Showing with 41 additions and 28 deletions.
  1. +22 −15 pkgs/development/interpreters/guile/1.8.nix
  2. +10 −7 pkgs/development/interpreters/guile/2.0.nix
  3. +9 −6 pkgs/development/interpreters/guile/default.nix
37 changes: 22 additions & 15 deletions pkgs/development/interpreters/guile/1.8.nix
Original file line number Diff line number Diff line change
@@ -1,25 +1,33 @@
{ fetchurl, stdenv, libtool, readline, gmp
, gawk, makeWrapper }:
{ stdenv, buildPackages
, buildPlatform, hostPlatform
, fetchurl, makeWrapper, gawk, pkgconfig
, libtool, readline, gmp
}:

stdenv.mkDerivation rec {
name = "guile-1.8.8";

src = fetchurl {
url = "mirror://gnu/guile/" + name + ".tar.gz";
url = "mirror://gnu/guile/${name}.tar.gz";
sha256 = "0l200a0v7h8bh0cwz6v7hc13ds39cgqsmfrks55b1rbj5vniyiy3";
};

patches = [ ./cpp-4.5.patch ];

outputs = [ "out" "dev" "info" ];
setOutputFlags = false; # $dev gets into the library otherwise

# GCC 4.6 raises a number of set-but-unused warnings.
configureFlags = [ "--disable-error-on-warning" ];

nativeBuildInputs = [ makeWrapper gawk ];
propagatedBuildInputs = [ readline gmp libtool ];
selfNativeBuildInput = true;
depsBuildBuild = [ buildPackages.stdenv.cc ]
++ stdenv.lib.optional (hostPlatform != buildPlatform)
buildPackages.buildPackages.guile_1_8;
nativeBuildInputs = [ makeWrapper gawk pkgconfig ];
buildInputs = [ readline libtool ];

propagatedBuildInputs = [ gmp ];

patches = [ ./cpp-4.5.patch ];


postInstall = ''
wrapProgram $out/bin/guile-snarf --prefix PATH : "${gawk}/bin"
@@ -46,17 +54,16 @@ stdenv.mkDerivation rec {
setupHook = ./setup-hook.sh;

meta = {
description = "GNU Guile, an embeddable Scheme interpreter";
description = "Embeddable Scheme implementation";
homepage = http://www.gnu.org/software/guile/;
license = stdenv.lib.licenses.lgpl2Plus;
maintainers = [ stdenv.lib.maintainers.ludo ];
platforms = stdenv.lib.platforms.unix;

longDescription = ''
GNU Guile is an interpreter for the Scheme programming language,
packaged as a library that can be embedded into programs to make
them extensible. It supports many SRFIs.
'';

homepage = http://www.gnu.org/software/guile/;
license = stdenv.lib.licenses.lgpl2Plus;

maintainers = [ stdenv.lib.maintainers.ludo ];
platforms = stdenv.lib.platforms.unix;
};
}
17 changes: 10 additions & 7 deletions pkgs/development/interpreters/guile/2.0.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{ fetchurl, stdenv, libtool, readline, gmp, pkgconfig, boehmgc, libunistring
, libffi, gawk, makeWrapper, fetchpatch, coverageAnalysis ? null, gnu ? null
, hostPlatform, buildPackages
{ stdenv, buildPackages
, buildPlatform, hostPlatform
, fetchpatch, fetchurl, makeWrapper, gawk, pkgconfig
, libffi, libtool, readline, gmp, boehmgc, libunistring
, coverageAnalysis ? null, gnu ? null
}:

# Do either a coverage analysis build or a standard build.
@@ -19,12 +21,13 @@
outputs = [ "out" "dev" "info" ];
setOutputFlags = false; # $dev gets into the library otherwise

depsBuildBuild = [ buildPackages.stdenv.cc ];
nativeBuildInputs = [ makeWrapper gawk pkgconfig ] ++
stdenv.lib.optional stdenv.isCross buildPackages.buildPackages.guile_2_0;
depsBuildBuild = [ buildPackages.stdenv.cc ]
++ stdenv.lib.optional (hostPlatform != buildPlatform)
buildPackages.buildPackages.guile_2_0;
nativeBuildInputs = [ makeWrapper gawk pkgconfig ];
buildInputs = [ readline libtool libunistring libffi ];
propagatedBuildInputs = [ gmp boehmgc ]

propagatedBuildInputs = [ gmp boehmgc ]
# XXX: These ones aren't normally needed here, but since
# `libguile-2.0.la' reads `-lltdl -lunistring', adding them here will add
# the needed `-L' flags. As for why the `.la' file lacks the `-L' flags,
15 changes: 9 additions & 6 deletions pkgs/development/interpreters/guile/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{ fetchurl, stdenv, libtool, readline, gmp, pkgconfig, boehmgc, libunistring
, libffi, gawk, makeWrapper, fetchpatch, coverageAnalysis ? null, gnu ? null
, hostPlatform, buildPackages
{ stdenv, buildPackages
, buildPlatform, hostPlatform
, fetchurl, makeWrapper, gawk, pkgconfig
, libffi, libtool, readline, gmp, boehmgc, libunistring
, coverageAnalysis ? null, gnu ? null
}:

# Do either a coverage analysis build or a standard build.
@@ -20,9 +22,10 @@
outputs = [ "out" "dev" "info" ];
setOutputFlags = false; # $dev gets into the library otherwise

depsBuildBuild = [ buildPackages.stdenv.cc ];
nativeBuildInputs = [ makeWrapper gawk pkgconfig ] ++
stdenv.lib.optional stdenv.isCross buildPackages.buildPackages.guile;
depsBuildBuild = [ buildPackages.stdenv.cc ]
++ stdenv.lib.optional (hostPlatform != buildPlatform)
buildPackages.buildPackages.guile;
nativeBuildInputs = [ makeWrapper gawk pkgconfig ];
buildInputs = [ readline libtool libunistring libffi ];

propagatedBuildInputs = [ gmp boehmgc ]