Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv cross adapter: Get rid if selfNativeBuildInput #36401

Merged
merged 1 commit into from Mar 7, 2018
Merged

stdenv cross adapter: Get rid if selfNativeBuildInput #36401

merged 1 commit into from Mar 7, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Mar 7, 2018 •
edited

Motivation for this change

It is finally no longer used anywhere

Fixes #30587

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
stdenv cross adapter: Get rid if selfNativeBuildInput
8d58008 
It is finally no longer used anywhere

Fixes NixOS#30587
@Ericson2314 Ericson2314 merged commit 8f54d93 into NixOS:staging Mar 7, 2018
@Ericson2314 Ericson2314 deleted the no-stdenv-cross-adapter branch March 7, 2018 01:17
@Ericson2314
Copy link
Member Author

This is only on staging cause its prereqs were on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg