Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundler: 1.14.6 -> 1.16.1 #36409

Merged
merged 1 commit into from Mar 12, 2018
Merged

bundler: 1.14.6 -> 1.16.1 #36409

merged 1 commit into from Mar 12, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 7, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from zimbatm as a code owner March 7, 2018 08:28
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/fbbvzgri8gmzq1s5q68f6xh87771rhf4-bundler-1.16.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/fclqz0j2qhdn9nbw5s8crr1l8lpz2waq-bundler-1.16.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

WARNING:  You build with buildroot.
  Build root: /
  Bin dir: /nix/store/0rz0s2j24244b05mdl22pcsqh4ij0lik-bundler-1.16.1/lib/ruby/gems/2.4.0/bin
  Gem home: /nix/store/0rz0s2j24244b05mdl22pcsqh4ij0lik-bundler-1.16.1/lib/ruby/gems/2.4.0
Successfully installed bundler-1.16.1
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0rz0s2j24244b05mdl22pcsqh4ij0lik-bundler-1.16.1
checking for references to /build in /nix/store/0rz0s2j24244b05mdl22pcsqh4ij0lik-bundler-1.16.1...
/nix/store/0rz0s2j24244b05mdl22pcsqh4ij0lik-bundler-1.16.1

@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2018

cc @zimbatm @manveru

@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2018

more rebuilds then I initially expected.

@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2018

@vcunat you still would not call this a mass rebuild, yes?

@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2018

changelog: https://github.com/bundler/bundler/blob/master/CHANGELOG.md

@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2018

@GrahamcOfBorg build r10k

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

Successfully installed bundler-1.16.1
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fbbvzgri8gmzq1s5q68f6xh87771rhf4-bundler-1.16.1
checking for references to /tmp/nix-build-bundler-1.16.1.drv-0 in /nix/store/fbbvzgri8gmzq1s5q68f6xh87771rhf4-bundler-1.16.1...
building path(s) ‘/nix/store/xmgxplwczw36s0dicx6xqbq0jjgviss2-r10k-2.4.3-gems’
created 60 symlinks in user environment
building path(s) ‘/nix/store/rpq58kkdvk921pnl0wzjyk0s81ryrxka-r10k-2.4.3’
installing
/nix/store/rpq58kkdvk921pnl0wzjyk0s81ryrxka-r10k-2.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/dddngp3yhzansy0igmjfrqa0nkpnqa57-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/samples/hello_gtk_builder.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/x67rsi7x2hhj9jx7yji0w2jfxjrksjl3-ruby-2.4.3/bin/ruby"
/nix/store/dddngp3yhzansy0igmjfrqa0nkpnqa57-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/samples/hello_noop.rb: interpreter directive changed from "/usr/bin/ruby" to "/nix/store/x67rsi7x2hhj9jx7yji0w2jfxjrksjl3-ruby-2.4.3/bin/ruby"
/nix/store/dddngp3yhzansy0igmjfrqa0nkpnqa57-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/samples/hello_plural.rb: interpreter directive changed from "/usr/bin/ruby" to "/nix/store/x67rsi7x2hhj9jx7yji0w2jfxjrksjl3-ruby-2.4.3/bin/ruby"
/nix/store/dddngp3yhzansy0igmjfrqa0nkpnqa57-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/samples/hello_tk.rb: interpreter directive changed from "/usr/bin/ruby" to "/nix/store/x67rsi7x2hhj9jx7yji0w2jfxjrksjl3-ruby-2.4.3/bin/ruby"
/nix/store/dddngp3yhzansy0igmjfrqa0nkpnqa57-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/test/run-test.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/x67rsi7x2hhj9jx7yji0w2jfxjrksjl3-ruby-2.4.3/bin/ruby"
building '/nix/store/gnq5vj66sqxz9znfgcbhqlkgpbw5165n-r10k-2.4.3-gems.drv'...
created 60 symlinks in user environment
building '/nix/store/dmij3y9iqn7m2xrm2ph31rx9qj7kf6ih-r10k-2.4.3.drv'...
installing
/nix/store/grf8gghymd83d6i0hvf5x1qjwjaikaal-r10k-2.4.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/4by0hikb427df5c6kjxy2fpapri35mfi-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/bin/rmsgmerge: interpreter directive changed from " /usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
/nix/store/4by0hikb427df5c6kjxy2fpapri35mfi-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/bin/rmsginit: interpreter directive changed from " /usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
/nix/store/4by0hikb427df5c6kjxy2fpapri35mfi-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/bin/rmsgfmt: interpreter directive changed from " /usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
/nix/store/4by0hikb427df5c6kjxy2fpapri35mfi-ruby2.4.3-gettext-3.2.2/lib/ruby/gems/2.4.0/gems/gettext-3.2.2/bin/rmsgcat: interpreter directive changed from " /usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
checking for references to /build in /nix/store/4by0hikb427df5c6kjxy2fpapri35mfi-ruby2.4.3-gettext-3.2.2...
building '/nix/store/f969kqd60y76wqkhw7g35lwzr5vhiqpr-r10k-2.4.3-gems.drv'...
created 60 symlinks in user environment
building '/nix/store/bxnm5d45k8znq5xf3mz0k5d6i98j9qpg-r10k-2.4.3.drv'...
installing
/nix/store/xc078lfgj59i4lzzkd9n6clm089yn8xj-r10k-2.4.3

@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2018

@GrahamcOfBorg build gitlab

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘gitlab-env-10.3.4’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/build-support/trivial-builders.nix:7 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/6hghsdk4v6118j9vlyq9l5157j3df9qv-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/sign.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
/nix/store/6hghsdk4v6118j9vlyq9l5157j3df9qv-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/roundtrip.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
/nix/store/6hghsdk4v6118j9vlyq9l5157j3df9qv-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/keylist.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
/nix/store/6hghsdk4v6118j9vlyq9l5157j3df9qv-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/genkey.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
/nix/store/6hghsdk4v6118j9vlyq9l5157j3df9qv-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/edit.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/6hx1p4ci13bdg9ska62m1az888bz29sz-ruby-2.4.3/bin/ruby"
checking for references to /build in /nix/store/6hghsdk4v6118j9vlyq9l5157j3df9qv-ruby2.4.3-gpgme-2.0.13...
wrong ELF type
cannot build derivation '/nix/store/8n7d6q4v7j3wq0yxjcrw6jh0m51hpgr1-gitlab-env-10.3.4.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/109ksxsq520vs80hvijvp5hkxqpg7n1z-gitlab-10.3.4.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/109ksxsq520vs80hvijvp5hkxqpg7n1z-gitlab-10.3.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/b4ywzz86qbf4vc4y9bnbr9fvk93ab73z-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/genkey.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/dns77vf9frhd2s2xvcdd47rs2l08nqin-ruby-2.4.3/bin/ruby"
/nix/store/b4ywzz86qbf4vc4y9bnbr9fvk93ab73z-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/keylist.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/dns77vf9frhd2s2xvcdd47rs2l08nqin-ruby-2.4.3/bin/ruby"
/nix/store/b4ywzz86qbf4vc4y9bnbr9fvk93ab73z-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/verify.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/dns77vf9frhd2s2xvcdd47rs2l08nqin-ruby-2.4.3/bin/ruby"
/nix/store/b4ywzz86qbf4vc4y9bnbr9fvk93ab73z-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/sign.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/dns77vf9frhd2s2xvcdd47rs2l08nqin-ruby-2.4.3/bin/ruby"
/nix/store/b4ywzz86qbf4vc4y9bnbr9fvk93ab73z-ruby2.4.3-gpgme-2.0.13/lib/ruby/gems/2.4.0/gems/gpgme-2.0.13/examples/edit.rb: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/dns77vf9frhd2s2xvcdd47rs2l08nqin-ruby-2.4.3/bin/ruby"
checking for references to /tmp/nix-build-ruby2.4.3-gpgme-2.0.13.drv-0 in /nix/store/b4ywzz86qbf4vc4y9bnbr9fvk93ab73z-ruby2.4.3-gpgme-2.0.13...
wrong ELF type
cannot build derivation ‘/nix/store/c9vjjbng1j4390yvaldlya96n17cdf23-gitlab-env-10.3.4.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/zyw2b36090jlr5fmi8vazz1gdaz0lkig-gitlab-10.3.4.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/zyw2b36090jlr5fmi8vazz1gdaz0lkig-gitlab-10.3.4.drv’ failed

@vcunat
Copy link
Member

vcunat commented Mar 7, 2018

Probably. Depends on the exact number. IIRC we have ruby used as a build-time tool somewhere deep.

@Mic92 Mic92 mentioned this pull request Mar 8, 2018
Closed
@Mic92
Copy link
Member Author

Mic92 commented Mar 12, 2018

This update is critical and should be backported. Ruby 2.4.0 has a different bundler version then our bundler package. This breaks applications like vagrant.

@Mic92 Mic92 merged commit c3ccaed into NixOS:master Mar 12, 2018
@Mic92 Mic92 deleted the bundler branch March 12, 2018 18:02
@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 12, 2018
@Mic92 Mic92 added this to the 18.03 milestone Mar 12, 2018
@Mic92
Copy link
Member Author

Mic92 commented Mar 12, 2018

In case I forget please add this to 18.03.

@Mic92
Copy link
Member Author

Mic92 commented Mar 12, 2018

Reverted again 97fff8d8065e79e89972bc644d88787d7d37edf9 because this is known to break gitlab: #30881 (comment)

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @vcunat @samueldr