Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vo-amrwbenc: init at 0.1.3 #36413

Merged
merged 4 commits into from Mar 19, 2018
Merged

vo-amrwbenc: init at 0.1.3 #36413

merged 4 commits into from Mar 19, 2018

Conversation

Esteth
Copy link
Contributor

@Esteth Esteth commented Mar 7, 2018 •
edited

Motivation for this change

Adding new package for AMR-WB encoder/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Adam Copp added 2 commits March 7, 2018 11:04
Add vo-amrwbenc library package.
1efef6b 
With some changes to ffmpeg build file, this enables ffmpeg to perform
AMR-WB encoding.
Merge branch 'master' of https://github.com/Esteth/nixpkgs
828fdd4
@Esteth Esteth changed the title Add WMR-WB encoder package (vo-amrwbenc) vo-amrwbenc: init at 0.1.3 Mar 7, 2018
@Esteth
Copy link
Contributor Author

Esteth commented Mar 7, 2018

Do I need to find a way to test this on NixOS and/or macOS?

@matthewbauer
Copy link
Member

Works find on macOS for me. Can you add "platforms = stdenv.lib.platforms.unix;" to meta?

@Esteth
Copy link
Contributor Author

Esteth commented Mar 19, 2018

Done :)

@matthewbauer matthewbauer merged commit b31f9c0 into NixOS:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Esteth @matthewbauer @GrahamcOfBorg @Janik-Haag