Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocaml-ng.ocamlPackages_4_06.camlimages: 4.1.2 -> 5.0.0 #36412

Merged
merged 1 commit into from Mar 7, 2018
Merged

ocaml-ng.ocamlPackages_4_06.camlimages: 4.1.2 -> 5.0.0 #36412

merged 1 commit into from Mar 7, 2018

Conversation

mt-caret
Copy link
Contributor

@mt-caret mt-caret commented Mar 7, 2018

Motivation for this change

Bump camlimages (but only for OCaml 4.06).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mt-caret
Copy link
Contributor Author

mt-caret commented Mar 7, 2018

btw, camlimages doesn't seem to build on 4.05 (ping @vbgl)

@Mic92
Copy link
Member

Mic92 commented Mar 7, 2018

@GrahamcOfBorg build camlimages

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘camlimages’ in selection path ‘camlimages’ not found

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m attribute 'camlimages' in selection path 'camlimages' not found

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: attribute 'camlimages' in selection path 'camlimages' not found

@mt-caret
Copy link
Contributor Author

mt-caret commented Mar 7, 2018

@GrahamcOfBorg build ocamlPackages.camlimages ocaml-ng.ocamlPackages_4_06.camlimages

@mt-caret mt-caret changed the title camlimages: 4.1.2 -> 5.0.0 ocaml-ng.ocamlPackages_4_06.camlimages: 4.1.2 -> 5.0.0 Mar 7, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 7, 2018

@GrahamcOfBorg build ocamlPackages.camlimages ocaml-ng.ocamlPackages_4_06.camlimages

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

_build/install/default/lib/stublibs/dllcamlimages_xpm_stubs.so => /nix/store/yx7i6p9sjc20b3h6bhqkvbg3bw34n16p-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/stubslibs/dllcamlimages_xpm_stubs.so
Creating directory /nix/store/yx7i6p9sjc20b3h6bhqkvbg3bw34n16p-camlimages-5.0.0/doc/camlimages
_build/install/default/doc/camlimages/README.md => /nix/store/yx7i6p9sjc20b3h6bhqkvbg3bw34n16p-camlimages-5.0.0/doc/camlimages/README.md
post-installation fixup
moving /nix/store/yx7i6p9sjc20b3h6bhqkvbg3bw34n16p-camlimages-5.0.0/doc to /nix/store/yx7i6p9sjc20b3h6bhqkvbg3bw34n16p-camlimages-5.0.0/share/doc
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/yx7i6p9sjc20b3h6bhqkvbg3bw34n16p-camlimages-5.0.0/lib
patching script interpreter paths in /nix/store/yx7i6p9sjc20b3h6bhqkvbg3bw34n16p-camlimages-5.0.0
/nix/store/9xjyia2plzj0l09ni0phhan63hq9wsrh-camlimages-4.1.2
/nix/store/yx7i6p9sjc20b3h6bhqkvbg3bw34n16p-camlimages-5.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/tiff/camlimages_tiff.cmxs
/nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0
shrinking /nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/jpeg/camlimages_jpeg.cmxs
shrinking /nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/exif/camlimages_exif.cmxs
shrinking /nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/gif/camlimages_gif.cmxs
shrinking /nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/freetype/camlimages_freetype.cmxs
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0/lib 
patching script interpreter paths in /nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0
checking for references to /tmp/nix-build-camlimages-5.0.0.drv-0 in /nix/store/p2ckjvsndj6w0r42q23m5h57qabrwlsl-camlimages-5.0.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/9y1y68pl5bdg68b184c4kz1sa9sn9r7r-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/gif/camlimages_gif.cmxs
shrinking /nix/store/9y1y68pl5bdg68b184c4kz1sa9sn9r7r-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/freetype/camlimages_freetype.cmxs
shrinking /nix/store/9y1y68pl5bdg68b184c4kz1sa9sn9r7r-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/exif/camlimages_exif.cmxs
shrinking /nix/store/9y1y68pl5bdg68b184c4kz1sa9sn9r7r-camlimages-5.0.0/lib/ocaml/4.06.1/site-lib/camlimages/core/camlimages.cmxs
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9y1y68pl5bdg68b184c4kz1sa9sn9r7r-camlimages-5.0.0/lib
patching script interpreter paths in /nix/store/9y1y68pl5bdg68b184c4kz1sa9sn9r7r-camlimages-5.0.0
checking for references to /build in /nix/store/9y1y68pl5bdg68b184c4kz1sa9sn9r7r-camlimages-5.0.0...
/nix/store/7vivic2lgh1cch56rgj6y5czi7cvrs35-camlimages-4.1.2
/nix/store/9y1y68pl5bdg68b184c4kz1sa9sn9r7r-camlimages-5.0.0

@Mic92 Mic92 merged commit 906713a into NixOS:master Mar 7, 2018
@vbgl
Copy link
Contributor

vbgl commented Mar 7, 2018

Please give a second look at CONTRIBUTING.md and populate the meta attribute.

@mt-caret
Copy link
Contributor Author

mt-caret commented Mar 7, 2018 •
edited

Sorry, completely forgot about that; who should be the maintainer in this case?
@vbgl I'm ok with maintaining 5.0.0, but maybe multiple versions of the same package should be maintained by the same person?

@mt-caret mt-caret mentioned this pull request Mar 7, 2018
Merged
@vbgl
Copy link
Contributor

vbgl commented Mar 7, 2018

ocaml-ng.ocamlPackages_4_05.camlimages is now broken.

@mt-caret mt-caret mentioned this pull request Mar 8, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mt-caret @Mic92 @GrahamcOfBorg @vbgl