Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 2.3.0 -> 2.4.0 #36400

Merged
merged 1 commit into from Mar 7, 2018
Merged

radare2: 2.3.0 -> 2.4.0 #36400

merged 1 commit into from Mar 7, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 7, 2018 •
edited

Motivation for this change

cc @makefu @dtzWill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2018

@GrahamcOfBorg build radare2

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘radare2-2.4.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/tools/analysis/radare2/default.nix:50 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92
Copy link
Member Author

Mic92 commented Mar 7, 2018

changelog: https://github.com/radare/radare2/releases/tag/2.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/lib/libr_bp.so.2.4.0
shrinking /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/lib/libr_util.so.2.4.0
gzipping man pages under /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/lib  /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/bin 
patching script interpreter paths in /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0
/nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-radare2-2.4.0.drv-0 in /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0...
/nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0/lib/libr_asm.so.2.4.0
shrinking /nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0/lib/libr_anal.so.2.4.0
gzipping man pages under /nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0/lib  /nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0/bin
patching script interpreter paths in /nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0
/nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0...
/nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘radare2-2.4.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/analysis/radare2/default.nix:50 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/h83i3b192fjxljamv7idydsk8mm9zxz8-radare2-2.4.0

makefu
makefu approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dtzWill
dtzWill approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@dtzWill dtzWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/lib/libr_bp.so.2.4.0
shrinking /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/lib/libr_util.so.2.4.0
gzipping man pages under /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/lib  /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/bin 
patching script interpreter paths in /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0
/nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-radare2-2.4.0.drv-0 in /nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0...
/nix/store/4qydrlm8ldxy055y921ip02a9bdvy73w-radare2-2.4.0

@Mic92 Mic92 merged commit dc1e064 into NixOS:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu makefu approved these changes

@dtzWill dtzWill dtzWill approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @makefu @dtzWill