Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-daemon.nix: fix requireSignedBinaryCaches with Nix 1.11 #36402

Closed
wants to merge 1 commit into from
Closed

nix-daemon.nix: fix requireSignedBinaryCaches with Nix 1.11 #36402

wants to merge 1 commit into from

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Mar 7, 2018

Motivation for this change

It turns out that in Nix 1.11, if the signed-binary-caches option is set
to an empty string, it will still require a signed binary cache.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@wizeman
nix-daemon.nix: fix requireSignedBinaryCaches with Nix 1.11
7716c09 
It turns out that in Nix 1.11, if the signed-binary-caches option is set
to an empty string, it will still require a signed binary cache.
@wizeman
Copy link
Member Author

wizeman commented Mar 7, 2018

This should probably be backported to 17.09, as the bug is also present there.

@wizeman
Copy link
Member Author

wizeman commented Mar 7, 2018

FYI, this bug was introduced by commit 700e21d.

@mmahut
Copy link
Member

mmahut commented Aug 3, 2019

What is the status of this pull request?

@wizeman
Copy link
Member Author

wizeman commented Aug 5, 2019

I think the fix is still valid, but I'm not sure how much we still care about Nix 1.11. Although, in that case we should probably remove all that < Nix 2.0 conditional code.
I don't think it's worth it to backport to 17.09 anymore.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@wizeman
Copy link
Member Author

wizeman commented Jun 2, 2020

I believe this is no longer needed.

@wizeman wizeman closed this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wizeman @mmahut @GrahamcOfBorg