Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cl-launch: change platforms to unix #36403

Merged
merged 1 commit into from Mar 7, 2018
Merged

cl-launch: change platforms to unix #36403

merged 1 commit into from Mar 7, 2018

Conversation

elts
Copy link
Contributor

@elts elts commented Mar 7, 2018

Motivation for this change

this will alow to build / use cl-launch on other platforms
e.g. MacOS, FreeBSD

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@elts
cl-launch: change platforms to unix
c6fdf69 
this will alow to build / use cl-launch on other platforms
e.g. MacOS, FreeBSD
@elts
Copy link
Contributor Author

elts commented Mar 7, 2018

Forgot to mention maintainer: cc @7c6f434c

@Mic92
Copy link
Member

Mic92 commented Mar 7, 2018

@GrahamcOfBorg build cl-launch

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (0.03 MiB download, 0.10 MiB unpacked):
  /nix/store/gzs7xqsfh0zi9jmaaan0ngwa3z6pll61-cl-launch-4.1.4.1
copying path '/nix/store/gzs7xqsfh0zi9jmaaan0ngwa3z6pll61-cl-launch-4.1.4.1' from 'https://cache.nixos.org'...
/nix/store/gzs7xqsfh0zi9jmaaan0ngwa3z6pll61-cl-launch-4.1.4.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

these paths will be fetched (0.03 MiB download, 0.10 MiB unpacked):
  /nix/store/wvzlyawiwvlrgprkgg4xkx4jhfyjpp3l-cl-launch-4.1.4.1
fetching path ‘/nix/store/wvzlyawiwvlrgprkgg4xkx4jhfyjpp3l-cl-launch-4.1.4.1’...

*** Downloading ‘https://cache.nixos.org/nar/03rhw7i2lk8ax5vm37w76rfhfvqbg3l4h2h5fchzswwvghzmlyb1.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/wvzlyawiwvlrgprkgg4xkx4jhfyjpp3l-cl-launch-4.1.4.1’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 29660  100 29660    0     0   226k      0 --:--:-- --:--:-- --:--:--  226k

/nix/store/wvzlyawiwvlrgprkgg4xkx4jhfyjpp3l-cl-launch-4.1.4.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

Linking .asd file for cl-launch into '/nix/store/h0dna1bjqgzc6i6v9xf3kqfqfhdrpjil-cl-launch-4.1.4.1'/share/common-lisp/systems/
cc -Os -s -W -Wall -Werror -DCL_LAUNCH_SCRIPT="\"'/nix/store/h0dna1bjqgzc6i6v9xf3kqfqfhdrpjil-cl-launch-4.1.4.1'/bin/cl-launch\"" -o cl-shim cl-shim.c
ld: warning: option -s is obsolete and being ignored
cp -p cl-shim '/nix/store/h0dna1bjqgzc6i6v9xf3kqfqfhdrpjil-cl-launch-4.1.4.1'/bin/cl
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/h0dna1bjqgzc6i6v9xf3kqfqfhdrpjil-cl-launch-4.1.4.1/bin
patching script interpreter paths in /nix/store/h0dna1bjqgzc6i6v9xf3kqfqfhdrpjil-cl-launch-4.1.4.1
/nix/store/h0dna1bjqgzc6i6v9xf3kqfqfhdrpjil-cl-launch-4.1.4.1/bin/cl-launch: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/h0dna1bjqgzc6i6v9xf3kqfqfhdrpjil-cl-launch-4.1.4.1

@7c6f434c 7c6f434c merged commit 07be75d into NixOS:master Mar 7, 2018
vcunat pushed a commit that referenced this pull request Mar 7, 2018
@7c6f434c @vcunat
Merge pull request #36403 from elts/fix/cl-launch
e4f2f02 
cl-launch: change platforms to unix
(cherry picked from commit 07be75d)
@elts elts deleted the fix/cl-launch branch June 11, 2018 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elts @Mic92 @GrahamcOfBorg @7c6f434c