Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-notify2: init at 0.3.1 #35262

Closed
wants to merge 1 commit into from
Closed

python-notify2: init at 0.3.1 #35262

wants to merge 1 commit into from

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Feb 21, 2018 •
edited

Motivation for this change

i was requested to break this into two prs here #35245

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mogorman mogorman requested a review from FRidh as a code owner February 21, 2018 09:11
@dotlambda
Copy link
Member

I actually meant 2 commits, not 2 PRs :D

@mogorman
Copy link
Contributor Author

@dotlambda after this is merged i can modify the pulseaudio-dlna pr to not have the otify2 part as it will be in master

@mogorman mogorman closed this Feb 21, 2018
@mogorman mogorman deleted the notify2 branch February 21, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mogorman @dotlambda @GrahamcOfBorg