Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parity: ethereum client #35263

Closed
wants to merge 7 commits into from
Closed

Parity: ethereum client #35263

wants to merge 7 commits into from

Conversation

akru
Copy link
Contributor

@akru akru commented Feb 21, 2018 •
edited

Motivation for this change

This is clean version of #34441.

Added two versions of Parity ethereum client (https://parity.io):

  • parity v1.8.11
  • parity-beta v1.9.4
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@akru akru mentioned this pull request Feb 21, 2018
Closed
8 tasks
Mic92
Mic92 reviewed Feb 21, 2018
View reviewed changes
pkgs/applications/altcoins/parity/beta.nix Outdated
version = "1.9.3";
sha256 = "19qyp6kafnnfhdnbq745v8zybnqizjzzc3k4701ly9hf0dvx53ka";
cargoSha256 = "1vdvqs6ligp5fkw5s7v44vwqwz5dqa0ipilx0piz6swz0drilima";
patches = [ ./patches/vendored-sources-1.9.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should just accept #34034
Probably we could add a flag to explicitly unlock git repo support. Then we know, which packages we need to fix in case there breakage in cargo-vendor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be cool to drop this patches, but as I see PR is WIP, is it will merged in near time?

@Mic92
Copy link
Member

Mic92 commented Mar 1, 2018

yeah, I have an idea on how to solve this. But it can be brought up later:
@GrahamcOfBorg build parity parity-beta

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: while evaluating the attribute 'buildInputs' of the derivation 'parity-1.8.10' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating 'getOutput' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/attrsets.nix:450:23, called from undefined position:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:97:17, called from undefined position:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13720:13:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/systemd/default.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/systemd/default.nix:14:1

Mic92
Mic92 reviewed Mar 1, 2018
View reviewed changes
pkgs/applications/altcoins/parity/parity.nix
description = "Fast, light, robust Ethereum implementation";
homepage = http://parity.io;
license = licenses.gpl3;
maintainers = [ maintainers.akru ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify platforms here? In doubt only add those, where you have tested it actually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, set linux.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q30yb0il8x4q7lpjfpgq485gdgynjjfk-parity-1.8.10
shrinking /nix/store/q30yb0il8x4q7lpjfpgq485gdgynjjfk-parity-1.8.10/bin/parity
shrinking /nix/store/q30yb0il8x4q7lpjfpgq485gdgynjjfk-parity-1.8.10/bin/librlp_derive.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/q30yb0il8x4q7lpjfpgq485gdgynjjfk-parity-1.8.10/bin 
patching script interpreter paths in /nix/store/q30yb0il8x4q7lpjfpgq485gdgynjjfk-parity-1.8.10
checking for references to /tmp/nix-build-parity-1.8.10.drv-0 in /nix/store/q30yb0il8x4q7lpjfpgq485gdgynjjfk-parity-1.8.10...
/nix/store/q30yb0il8x4q7lpjfpgq485gdgynjjfk-parity-1.8.10
/nix/store/kf8ijfhaca84prc3907h2fhwmjy5hm46-parity-1.9.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0vp8p7xqfl3y21m5qqgxc3rm807mmky2-parity-1.8.10
shrinking /nix/store/0vp8p7xqfl3y21m5qqgxc3rm807mmky2-parity-1.8.10/bin/librlp_derive.so
shrinking /nix/store/0vp8p7xqfl3y21m5qqgxc3rm807mmky2-parity-1.8.10/bin/parity
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0vp8p7xqfl3y21m5qqgxc3rm807mmky2-parity-1.8.10/bin
patching script interpreter paths in /nix/store/0vp8p7xqfl3y21m5qqgxc3rm807mmky2-parity-1.8.10
checking for references to /build in /nix/store/0vp8p7xqfl3y21m5qqgxc3rm807mmky2-parity-1.8.10...
/nix/store/0vp8p7xqfl3y21m5qqgxc3rm807mmky2-parity-1.8.10
/nix/store/dyh7gfimv3qr84j1sqy2650mla5q7l4j-parity-1.9.3

@Mic92 Mic92 closed this in 20a91ae Mar 9, 2018
@akru
Copy link
Contributor Author

akru commented Mar 9, 2018

Hello, @Mic92!
Can you explain why PR is not merged?

@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018 •
edited

@akru it is kind of merged. I had to rebased it in 20a91ae because the maintainers file changed and I resolved a merge conflict that way. The github UI is not ideal here, I agree.

@akru
Copy link
Contributor Author

akru commented Mar 9, 2018

Oh, thank you @Mic92!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akru @Mic92 @GrahamcOfBorg