Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapraid: 11.1 -> 11.2 #35272

Merged
merged 1 commit into from Feb 21, 2018
Merged

snapraid: 11.1 -> 11.2 #35272

merged 1 commit into from Feb 21, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @makefu

@Mic92
Copy link
Member

Mic92 commented Feb 21, 2018

@GrahamcOfBorg build snapraid

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

  /nix/store/5wxjmr5ahlnk2ljkhv5fia1w46qv8ajp-coreutils-8.29/bin/install -c snapraid '/nix/store/hd9ybpkc0wqivr4pbmn5d5xb8jmsf2yv-snapraid-11.2/bin'
 /nix/store/5wxjmr5ahlnk2ljkhv5fia1w46qv8ajp-coreutils-8.29/bin/mkdir -p '/nix/store/hd9ybpkc0wqivr4pbmn5d5xb8jmsf2yv-snapraid-11.2/share/man/man1'
 /nix/store/5wxjmr5ahlnk2ljkhv5fia1w46qv8ajp-coreutils-8.29/bin/install -c -m 644 snapraid.1 '/nix/store/hd9ybpkc0wqivr4pbmn5d5xb8jmsf2yv-snapraid-11.2/share/man/man1'
make[1]: Leaving directory '/private/tmp/nix-build-snapraid-11.2.drv-0/snapraid'
post-installation fixup
gzipping man pages under /nix/store/hd9ybpkc0wqivr4pbmn5d5xb8jmsf2yv-snapraid-11.2/share/man/
strip is /nix/store/v8ifq0hapblpr2z0hx4wvwg02w4aczqy-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/hd9ybpkc0wqivr4pbmn5d5xb8jmsf2yv-snapraid-11.2/bin
patching script interpreter paths in /nix/store/hd9ybpkc0wqivr4pbmn5d5xb8jmsf2yv-snapraid-11.2
/nix/store/hd9ybpkc0wqivr4pbmn5d5xb8jmsf2yv-snapraid-11.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/snapraid'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nj3qp9jannjqx7bj1yf2vpdq5p54byj9-snapraid-11.2
shrinking /nix/store/nj3qp9jannjqx7bj1yf2vpdq5p54byj9-snapraid-11.2/bin/snapraid
gzipping man pages under /nix/store/nj3qp9jannjqx7bj1yf2vpdq5p54byj9-snapraid-11.2/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nj3qp9jannjqx7bj1yf2vpdq5p54byj9-snapraid-11.2/bin
patching script interpreter paths in /nix/store/nj3qp9jannjqx7bj1yf2vpdq5p54byj9-snapraid-11.2
checking for references to /build in /nix/store/nj3qp9jannjqx7bj1yf2vpdq5p54byj9-snapraid-11.2...
/nix/store/nj3qp9jannjqx7bj1yf2vpdq5p54byj9-snapraid-11.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/snapraid'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2a6ay6v413n7pb458x8m8ixnhm0z430q-snapraid-11.2
shrinking /nix/store/2a6ay6v413n7pb458x8m8ixnhm0z430q-snapraid-11.2/bin/snapraid
gzipping man pages under /nix/store/2a6ay6v413n7pb458x8m8ixnhm0z430q-snapraid-11.2/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2a6ay6v413n7pb458x8m8ixnhm0z430q-snapraid-11.2/bin
patching script interpreter paths in /nix/store/2a6ay6v413n7pb458x8m8ixnhm0z430q-snapraid-11.2
checking for references to /build in /nix/store/2a6ay6v413n7pb458x8m8ixnhm0z430q-snapraid-11.2...
/nix/store/2a6ay6v413n7pb458x8m8ixnhm0z430q-snapraid-11.2

Mic92
Mic92 reviewed Feb 21, 2018
View reviewed changes
pkgs/tools/filesystems/snapraid/default.nix Outdated
sha256 = "05hq1478k61pa1hzg6xjaw63z6nba3yd7k2fxsxpb1fw06j5ywmj";
# needed by git for determining the version number
deepClone = true;
leaveDotGit = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, this is always ugly and often break the checksum. Is it possible to do a simple patch instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simple say VERSION=version; in nix to make it a environment variable: https://github.com/amadvance/snapraid/blob/f31dfada3e52e03487d4f68cfacb3b984381385b/autover.sh#L14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. This is a much better choice.

@Mic92 Mic92 merged commit 5767be7 into NixOS:master Feb 21, 2018
@jfrankenau jfrankenau deleted the update-snapraid branch February 21, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @Mic92 @GrahamcOfBorg