Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: fix extensionPack's hash, fixes #34846 #35271

Merged
merged 1 commit into from Feb 21, 2018
Merged

virtualbox: fix extensionPack's hash, fixes #34846 #35271

merged 1 commit into from Feb 21, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Fix #34846.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Feb 21, 2018

Is master also affected?

@jfrankenau
Copy link
Member Author

No, virtualbox on master is already on 5.2 and the extension pack's hash is correctly hex-encoded. This was just a mistake in 13c7daa as can easily be seen by the length of the hash.

@Mic92 Mic92 merged commit bbcd0ef into NixOS:release-17.09 Feb 21, 2018
@jfrankenau jfrankenau deleted the fix-virtualbox-extpack-hash branch February 21, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @Mic92 @GrahamcOfBorg