Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpdf: fix icons on Darwin #36191

Merged
merged 1 commit into from Mar 2, 2018
Merged

xpdf: fix icons on Darwin #36191

merged 1 commit into from Mar 2, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 1, 2018

Motivation for this change

Fixes: #36188

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl
xpdf: specify paths to Qt plugins
a3c57ac 
On Darwing this fixes icons and "native" look.

Fixes: NixOS#36188
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/rnffzbamnzmycrqbsbrwxn2vyi6q9x4w-xpdf-4.00

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

-- Installing: /nix/store/wjmcwgw81kvnaxplc5lv8wm35rfqaq52-xpdf-4.00/bin/xpdf
-- Installing: /nix/store/wjmcwgw81kvnaxplc5lv8wm35rfqaq52-xpdf-4.00/man/man1/xpdf.1
post-installation fixup
moving /nix/store/wjmcwgw81kvnaxplc5lv8wm35rfqaq52-xpdf-4.00/man to /nix/store/wjmcwgw81kvnaxplc5lv8wm35rfqaq52-xpdf-4.00/share/man
gzipping man pages under /nix/store/wjmcwgw81kvnaxplc5lv8wm35rfqaq52-xpdf-4.00/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/wjmcwgw81kvnaxplc5lv8wm35rfqaq52-xpdf-4.00/bin
patching script interpreter paths in /nix/store/wjmcwgw81kvnaxplc5lv8wm35rfqaq52-xpdf-4.00
postPatchMkspecs
/nix/store/wjmcwgw81kvnaxplc5lv8wm35rfqaq52-xpdf-4.00

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/6f6jnnpvj312kjyk0dgccbs9a5y99687-xpdf-4.00/bin/pdftohtml
shrinking /nix/store/6f6jnnpvj312kjyk0dgccbs9a5y99687-xpdf-4.00/bin/pdftotext
shrinking /nix/store/6f6jnnpvj312kjyk0dgccbs9a5y99687-xpdf-4.00/bin/pdftops
gzipping man pages under /nix/store/6f6jnnpvj312kjyk0dgccbs9a5y99687-xpdf-4.00/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/6f6jnnpvj312kjyk0dgccbs9a5y99687-xpdf-4.00/bin
patching script interpreter paths in /nix/store/6f6jnnpvj312kjyk0dgccbs9a5y99687-xpdf-4.00
checking for references to /build in /nix/store/6f6jnnpvj312kjyk0dgccbs9a5y99687-xpdf-4.00...
postPatchMkspecs
/nix/store/6f6jnnpvj312kjyk0dgccbs9a5y99687-xpdf-4.00

@LnL7 LnL7 merged commit c863a43 into NixOS:master Mar 2, 2018
@veprbl veprbl deleted the xpdf_fixes branch April 15, 2018 22:35
@veprbl veprbl restored the xpdf_fixes branch December 1, 2020 16:47
@veprbl veprbl deleted the xpdf_fixes branch December 1, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @LnL7