pythonPackages.requests-unixsocket: init at 0.1.5 #35056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
requested changes
Feb 18, 2018
| meta = { | ||
| description = "Use requests to talk HTTP via a UNIX domain socket"; | ||
| homepage = https://github.com/msabramo/requests-unixsocket; | ||
| license = lib.licenses.apache2; |
| # ported to use the now-upstream pytest log capture functionality | ||
| doCheck = false; | ||
|
|
||
| meta = { |
| description = "Use requests to talk HTTP via a UNIX domain socket"; | ||
| homepage = https://github.com/msabramo/requests-unixsocket; | ||
| license = lib.licenses.apache2; | ||
| maintainers = [ lib.maintainers.catern ]; |
|
|
||
| propagatedBuildInputs = [ requests ]; | ||
|
|
||
| # has unpackaged test dependency pytest-capturelog, should be |
There was a problem hiding this comment.
Would it be too big an effort to package pytest-capturelog?
There was a problem hiding this comment.
I think it would be unnecessary, since not only is that functionality now upstream, there's a more popular fork "pytest-catchlog" which is packaged. Also, there are other unpackaged test deps besides that one.
|
@GrahamcOfBorg build python2.pkgs.requests-unixsocket python3.pkgs.requests-unixsocket |
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
dotlambda
reviewed
Feb 19, 2018
| meta = with lib; { | ||
| description = "Use requests to talk HTTP via a UNIX domain socket"; | ||
| homepage = https://github.com/msabramo/requests-unixsocket; | ||
| license = licenses.asl2; |
There was a problem hiding this comment.
Sorry, it should have been asl20.
|
@GrahamcOfBorg build python2.pkgs.requests-unixsocket python3.pkgs.requests-unixsocket |
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
|
|
To enable the tests: diff --git a/pkgs/development/python-modules/requests-unixsocket/default.nix b/pkgs/development/python-modules/requests-unixsocket/default.nix
index 08e7c9537da..d67e8881110 100644
--- a/pkgs/development/python-modules/requests-unixsocket/default.nix
+++ b/pkgs/development/python-modules/requests-unixsocket/default.nix
@@ -1,4 +1,6 @@
-{ lib, buildPythonPackage, fetchPypi, pbr, requests }:
+{ lib, buildPythonPackage, fetchPypi
+, pbr, requests
+, pytest, pytestpep8, waitress }:
buildPythonPackage rec {
pname = "requests-unixsocket";
@@ -12,9 +14,11 @@ buildPythonPackage rec {
nativeBuildInputs = [ pbr ];
propagatedBuildInputs = [ requests ];
- # has unpackaged test dependency pytest-capturelog, should be
- # ported to use the now-upstream pytest log capture functionality
- doCheck = false;
+ checkInputs = [ pytest pytestpep8 waitress ];
+
+ checkPhase = ''
+ py.test
+ '';
meta = with lib; {
description = "Use requests to talk HTTP via a UNIX domain socket"; |
|
@GrahamcOfBorg build python2.pkgs.requests-unixsocket python3.pkgs.requests-unixsocket |
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.requests-unixsocket, python3.pkgs.requests-unixsocket Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.requests-unixsocket, python3.pkgs.requests-unixsocket Partial log (click to expand)
|
dotlambda
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.