Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-update-scripts: fix compatibility with Nix unstable #35035

Merged
merged 1 commit into from Feb 17, 2018
Merged

common-update-scripts: fix compatibility with Nix unstable #35035

merged 1 commit into from Feb 17, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 16, 2018

Motivation for this change

Broken by NixOS/nix@84722d6

cc @dezgeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar requested a review from dezgeg February 16, 2018 13:00
@dezgeg dezgeg merged commit 7934a0e into NixOS:master Feb 17, 2018
@jtojnar jtojnar deleted the update-source-version branch February 28, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @dezgeg @GrahamcOfBorg