refactor annotation-binder generated populators #5050
Merged
+305
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all seems fine, especially if it's slightly faster. Note the fix I made for legacy exts that have "compat" set to 1.8. FWIW I introduced the "packed" paths to try to shrink the amount of code we generate for populators and to reduce the amount of object churn booting up core classes. However I realize now that packing them doesn't reduce total strings since we still have to parse the names out, and may make things worse since they aren't coming from constant pool anymore. |
|
thanks for the review. |
from : ``` MethodIndex.addMethodReadFieldsPacked(1023, "instance_eval;instance_eval;instance_eval;instance_eval;instance_exec"); ``` ...to : ``` MethodIndex.addMethodReadFieldsPacked(1023, "instance_eval;instance_exec"); ```
(this avoids method lookups for aliases during boot)
kares
force-pushed
the
anno-binder-refactor
branch
from
18fa186 to
4e70b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accounts for a slight speed-up - the populator won't execute much 'redundant' code
this isn't the main issue with boot (compared to invokers) but still deserves a hand-craft