Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-generic-builder: override the provided outputs #35040

Closed
wants to merge 1 commit into from
Closed

haskell-generic-builder: override the provided outputs #35040

wants to merge 1 commit into from

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 16, 2018

Motivation for this change

Take the other flags into account to set the outputs attribute. Without
this change, the user has to be aware of the internal constructs of the
builder to set the outputs so they align with the other build flags.

Fixes #35032

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@zimbatm
haskell-generic-builder: override the provided outputs
6dfa923 
Take the other flags into account to set the outputs attribute. Without
this change, the user has to be aware of the internal constructs of the
builder to set the outputs so they align with the other build flags.
@zimbatm zimbatm requested a review from peti as a code owner February 16, 2018 14:20
@zimbatm zimbatm mentioned this pull request Feb 16, 2018
Closed
@zimbatm zimbatm closed this Feb 16, 2018
@zimbatm zimbatm deleted the haskell-enable-data-output branch February 16, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @GrahamcOfBorg