sayonara: init at 1.0.0-git5-20180115 #35046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build sayonara |
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
joachifm
reviewed
Feb 16, 2018
| sha256 = "1fl7zplnrrvbv1xm4g348bpd46jj39jvbm808hyjjq92i64wqg37"; | ||
| }; | ||
|
|
||
| buildInputs = [ cmake qt5.qtbase qt5.qttools zlib taglib pkgconfig pcre gst_all_1.gstreamer gst_all_1.gst-plugins-base gst_all_1.gst-plugins-good gst_all_1.gst-plugins-ugly ]; |
There was a problem hiding this comment.
At least cmake and pkgconfig can be made into nativeBuildInputs
| mkdir build | ||
| cd build | ||
| runHook preConfigure | ||
| cmake .. \ |
There was a problem hiding this comment.
What about setting cmakeFlags ?
There was a problem hiding this comment.
@joachifm, do you have any particular suggestions?
There was a problem hiding this comment.
as in cmakeFlags = [ ... ]; & relying on the standard configure phase definition (potentially using preConfigure to create & enter build.
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
deepfire
force-pushed
the
sayonara-player
branch
3 times, most recently
from
54e8a20
to
86eec6f
Compare
|
@joachifm, all fixed now, I believe. |
joachifm
reviewed
Feb 17, 2018
| NIX_CFLAGS_COMPILE = "-I${gst_all_1.gst-plugins-base.dev}/include/gstreamer-1.0"; | ||
|
|
||
| cmakeFlags = [ | ||
| "-DCMAKE_BUILD_TYPE=Release" |
There was a problem hiding this comment.
This is set by default in the cmake setup hook, is it really necessary?
deepfire
force-pushed
the
sayonara-player
branch
from
86eec6f
to
a57a9d6
Compare
|
@GrahamcOfBorg build sayonara |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
@joachifm, do you feel there are any other blockers remaining? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #34024
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)