qmc2 : init at 0.195 #35057

bignaux · 2018-02-16T21:37:00Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

grahamc · 2018-03-08T19:26:22Z

grahamc · 2018-03-08T19:27:07Z

pkgs/misc/emulators/qmc2/default.nix

+
+  src = fetchurl {
+      url = "https://netix.dl.sourceforge.net/project/qmc2/qmc2/${version}/${name}.tar.gz";
+      #url = "mirror://sourceforge/projects/qmc2/files/qmc2/${version}/${name}.tar.gz/download";


Please delete this comment, and instead of using this netix... url use the mirror we have, like this: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/misc/mantisbt.nix#L13

problem is that mirror is broken for me, never works and i get their custom 404 ... boring SF.

grahamc · 2018-03-08T19:27:27Z

pkgs/misc/emulators/qmc2/default.nix

+, minizip, zlib
+, qtbase, qtsvg, qtmultimedia, qtwebkit, qttranslations, qtxmlpatterns
+, rsync, SDL2, xwininfo
+, utillinux #colrm


Please delete the colrm comment

grahamc · 2018-03-08T19:27:43Z

pkgs/misc/emulators/qmc2/default.nix

+                  xwininfo zlib utillinux xorg.libxcb ];
+
+  makeFlags = [ #"DEFINES-=QMC2_BUNDLED_MINIZIP"
+                 #"DEFINES-=QMC2_BUNDLED_ZLIB"


Please delete these commented lines

i don't sucess to find good makeFlags to add them, so i'll keep in my maintainer notes for improve next time. Btw, it has no real consequences on the output.

grahamc · 2018-03-08T19:28:13Z

pkgs/misc/emulators/qmc2/default.nix

+
+  meta = with stdenv.lib; {
+    description = "A Qt frontend for MAME/MESS";
+    homepage = http://qmc2.batcom-it.net;


This URL supports HTTPS, so please switch to that

grahamc · 2018-03-08T19:29:09Z

lgtm other than these comments

bignaux · 2018-03-08T20:17:52Z

Thanks for review @grahamc .

grahamc · 2018-03-08T20:23:24Z

@GrahamcOfBorg build qmc2

GrahamcOfBorg · 2018-03-08T20:23:34Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘qmc2-0.195’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/misc/emulators/qmc2/default.nix:30 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-03-08T20:24:03Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

                 from qmc2main.cpp:43:
joystick.h:11:10: fatal error: SDL.h: No such file or directory
 #include <SDL.h>
          ^~~~~~~
compilation terminated.
make[1]: *** [Makefile.qmake:2888: qmc2main.o] Error 1
make[1]: Leaving directory '/tmp/nix-build-qmc2-0.195.drv-0/qmc2'
make: *** [Makefile:1043: qmc2-bin] Error 2
builder for ‘/nix/store/hqzqvpdj7yq51719zqm8ik5iifzfnbap-qmc2-0.195.drv’ failed with exit code 2
error: build of ‘/nix/store/hqzqvpdj7yq51719zqm8ik5iifzfnbap-qmc2-0.195.drv’ failed

GrahamcOfBorg · 2018-03-08T20:24:42Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

                 from qmc2main.cpp:43:
joystick.h:11:10: fatal error: SDL.h: No such file or directory
 #include <SDL.h>
          ^~~~~~~
compilation terminated.
make[1]: *** [Makefile.qmake:2888: qmc2main.o] Error 1
make[1]: Leaving directory '/build/qmc2'
make: *** [Makefile:1043: qmc2-bin] Error 2
builder for '/nix/store/gvn1z007pmcm3lkn1jpkx8n2q4sckljz-qmc2-0.195.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/gvn1z007pmcm3lkn1jpkx8n2q4sckljz-qmc2-0.195.drv' failed

bignaux · 2018-03-08T21:12:57Z

@GrahamcOfBorg build qmc2

grahamc · 2018-03-08T21:52:57Z

@GrahamcOfBorg build qmc2

GrahamcOfBorg · 2018-03-08T21:53:25Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘qmc2-0.195’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/misc/emulators/qmc2/default.nix:34 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-03-08T22:19:59Z

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7jilbm0l68gsjffxyr1bsdpqm9yjf21j-qmc2-0.195
shrinking /nix/store/7jilbm0l68gsjffxyr1bsdpqm9yjf21j-qmc2-0.195/bin/qmc2-sdlmame
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7jilbm0l68gsjffxyr1bsdpqm9yjf21j-qmc2-0.195/bin 
patching script interpreter paths in /nix/store/7jilbm0l68gsjffxyr1bsdpqm9yjf21j-qmc2-0.195
checking for references to /tmp/nix-build-qmc2-0.195.drv-0 in /nix/store/7jilbm0l68gsjffxyr1bsdpqm9yjf21j-qmc2-0.195...
postPatchMkspecs
postPatchMkspecs
/nix/store/7jilbm0l68gsjffxyr1bsdpqm9yjf21j-qmc2-0.195

GrahamcOfBorg · 2018-03-08T22:42:27Z

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jrjz8isgjzdxg8jihvkja78p9lj9pmbl-qmc2-0.195
shrinking /nix/store/jrjz8isgjzdxg8jihvkja78p9lj9pmbl-qmc2-0.195/bin/qmc2-sdlmame
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jrjz8isgjzdxg8jihvkja78p9lj9pmbl-qmc2-0.195/bin
patching script interpreter paths in /nix/store/jrjz8isgjzdxg8jihvkja78p9lj9pmbl-qmc2-0.195
checking for references to /build in /nix/store/jrjz8isgjzdxg8jihvkja78p9lj9pmbl-qmc2-0.195...
postPatchMkspecs
postPatchMkspecs
/nix/store/jrjz8isgjzdxg8jihvkja78p9lj9pmbl-qmc2-0.195

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Feb 16, 2018

bignaux force-pushed the qmc2 branch 2 times, most recently from 6119b58 to a9078e8 Compare March 8, 2018 13:13

bignaux changed the title ~~qmc2 : init at 0.192~~ qmc2 : init at 0.195 Mar 8, 2018

grahamc reviewed Mar 8, 2018

View reviewed changes

bignaux force-pushed the qmc2 branch from a9078e8 to 52a26f4 Compare March 8, 2018 20:16

qmc2 : init at 0.195

a611114

bignaux force-pushed the qmc2 branch from 52a26f4 to a611114 Compare March 8, 2018 20:56

7c6f434c merged commit 00d6d77 into NixOS:master Mar 10, 2018

bignaux deleted the qmc2 branch March 10, 2018 13:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qmc2 : init at 0.195 #35057

qmc2 : init at 0.195 #35057

bignaux commented Feb 16, 2018 •

edited

grahamc commented Mar 8, 2018

grahamc Mar 8, 2018 •

edited

bignaux Mar 8, 2018

grahamc Mar 8, 2018

grahamc Mar 8, 2018

bignaux Mar 8, 2018

grahamc Mar 8, 2018

grahamc commented Mar 8, 2018

bignaux commented Mar 8, 2018

grahamc commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

bignaux commented Mar 8, 2018

grahamc commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

qmc2 : init at 0.195 #35057

qmc2 : init at 0.195 #35057

Conversation

bignaux commented Feb 16, 2018 • edited

Motivation for this change

Things done

grahamc commented Mar 8, 2018

grahamc Mar 8, 2018 • edited

Choose a reason for hiding this comment

bignaux Mar 8, 2018

Choose a reason for hiding this comment

grahamc Mar 8, 2018

Choose a reason for hiding this comment

grahamc Mar 8, 2018

Choose a reason for hiding this comment

bignaux Mar 8, 2018

Choose a reason for hiding this comment

grahamc Mar 8, 2018

Choose a reason for hiding this comment

grahamc commented Mar 8, 2018

bignaux commented Mar 8, 2018

grahamc commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

bignaux commented Mar 8, 2018

grahamc commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

GrahamcOfBorg commented Mar 8, 2018

bignaux commented Feb 16, 2018 •

edited

grahamc Mar 8, 2018 •

edited