Skip to content

slic3r-prusa3d: use system version for eigen and glew #35058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2018
Merged

slic3r-prusa3d: use system version for eigen and glew #35058

merged 2 commits into from
Feb 16, 2018
+6 −1

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Feb 16, 2018 •
edited
Loading

Motivation for this change

If we don't provide eigen and glew, vendored versions are used.

Also enabling parallel building, cmake should be robust enough for that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Moredread
slic3r-prusa3d: enable parallel building

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
26615e1
@Moredread
slic3r-prusa3d: use system version for eigen and glew

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
8d58c1e 
If we don't provide eigen and glew, vendored versions are used.
@Moredread Moredread force-pushed the slic3r-prusa-edition/deps branch from 4e88b23 to 8d58c1e Compare February 16, 2018 21:37
@joachifm
Copy link
Contributor

@GrahamcOfBorg build slic3r-prusa3d

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘slic3r-prusa-edition-1.38.7’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/misc/slic3r-prusa3d/default.nix:92 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 16, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d0amnn13hk7694krrwadi8mb7z4px8ck-slic3r-prusa-edition-1.38.7
shrinking /nix/store/d0amnn13hk7694krrwadi8mb7z4px8ck-slic3r-prusa-edition-1.38.7/lib/slic3r-prusa3d/auto/Slic3r/XS/XS.so
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/d0amnn13hk7694krrwadi8mb7z4px8ck-slic3r-prusa-edition-1.38.7/lib  /nix/store/d0amnn13hk7694krrwadi8mb7z4px8ck-slic3r-prusa-edition-1.38.7/bin
patching script interpreter paths in /nix/store/d0amnn13hk7694krrwadi8mb7z4px8ck-slic3r-prusa-edition-1.38.7
/nix/store/d0amnn13hk7694krrwadi8mb7z4px8ck-slic3r-prusa-edition-1.38.7/bin/.slic3r-prusa3d-wrapped: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/sxd8aswa0x5l34v34wjl8zrk6d5sagcx-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/d0amnn13hk7694krrwadi8mb7z4px8ck-slic3r-prusa-edition-1.38.7...
/nix/store/d0amnn13hk7694krrwadi8mb7z4px8ck-slic3r-prusa-edition-1.38.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1slgrqq5r1g0pmnai96x5w9021dya6wl-slic3r-prusa-edition-1.38.7
shrinking /nix/store/1slgrqq5r1g0pmnai96x5w9021dya6wl-slic3r-prusa-edition-1.38.7/lib/slic3r-prusa3d/auto/Slic3r/XS/XS.so
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1slgrqq5r1g0pmnai96x5w9021dya6wl-slic3r-prusa-edition-1.38.7/lib  /nix/store/1slgrqq5r1g0pmnai96x5w9021dya6wl-slic3r-prusa-edition-1.38.7/bin
patching script interpreter paths in /nix/store/1slgrqq5r1g0pmnai96x5w9021dya6wl-slic3r-prusa-edition-1.38.7
/nix/store/1slgrqq5r1g0pmnai96x5w9021dya6wl-slic3r-prusa-edition-1.38.7/bin/.slic3r-prusa3d-wrapped: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/fcb8ic4792clqckbb30xk0qa56gps6ya-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/1slgrqq5r1g0pmnai96x5w9021dya6wl-slic3r-prusa-edition-1.38.7...
/nix/store/1slgrqq5r1g0pmnai96x5w9021dya6wl-slic3r-prusa-edition-1.38.7

@joachifm joachifm merged commit b9214ee into NixOS:master Feb 16, 2018
@Moredread Moredread deleted the slic3r-prusa-edition/deps branch June 26, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @joachifm @GrahamcOfBorg