Remove mathn.rb from stdlib #5051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more information, please see feature #10169.
|
@nomadium Your previous changes to test/mri were ok because they reflected copies from MRI's test in their repo. When we resync those tests it ends up being zero sum since your submissions and those tests are identical. For ruby/spec (e.g. ruby/spec/ruby) they did not actually remove these files right? If anything they probably changed inclusive range from ..."2.5" to .."2.5". I am pretty sure those should not be touched. Perhaps we do need to update them to latest from ruby/spec though? |
|
I updaged stdlib from 2.5 yesterday, which included removing mathn.rb. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
This is another change targeting Ruby 2.5 [1]: Remove mathn from stdlib (feature #10169).
Thanks for your review and feedback.