New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitAndTools.hubUnstable: init at 2.3.0-pre10 #35044
Conversation
.github/PULL_REQUEST_TEMPLATE.md
. This feature is not released in a stable branch yet, so I updated to 2.3.0-pre10.
|
||
stdenv.mkDerivation rec { | ||
name = "hub-${version}"; | ||
version = "2.2.9"; | ||
version = "2.3.0-pre10"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we stick to stable versions unless there is a good reason (important bug fixes, fixes the build).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last stable, 2.2.9, was released in Oct 2016. It is quite old.
2.3.0-pre10 was released in June 2017, so it's not exactly new either.
According to their project board, I would say that a stable 2.3 is still a ways off. There's just one guy working on hub.
But the pre-release contains some very interesting features, and is fairly stable.
I understand the policy, and fully support it. But in this particular case, it's just a matter of upstream taking forever to produce something they want to label "stable".
Alternatively, @layus could submit a new package hubUnstable
or somesuch thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also thinking to submit a PR to get this version (for the ls
command).
I think adding the hubUnstable
attribute is a good tradeoff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's go for hubUnstable.
Thanks @layus ! |
[Edit] The unstable version is now in a separate package. This should therefore not more be a problem to merge this PR as the changes are in a new, different package [/Edit]
I really wanted the ability to make pull-requests that follow
.github/PULL_REQUEST_TEMPLATE.md
. This feature is not released in a stable branch yet, so I updated to 2.3.0-pre10.In the process, I refactored the build a bit to use the install script provided upstream.
This is why I decided to PR this change.
If there is strong apposition against comiting pre-release versions of hub, I will revert it to 2.2.9.
Motivation for this change
Refactor the build instructions:
/cc @the-kenny
Things done
./result/bin/
)