CB-252: Make whole row selectable in search results #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@brainzbot add to whitelist |
|
@ferbncode review this please? |
ferbncode
requested changes
Feb 26, 2018
| @@ -66,3 +66,8 @@ | |||
|
|
|||
| {% endif %} | |||
| {% endfor %} | |||
| <script type="text/javascript"> | |||
There was a problem hiding this comment.
I think it would be best to move this code to selector.html in the script block. Also, please add a comment to explain why we are doing this.
dpmittal
force-pushed
the
search_results
branch
from
d777772
to
ff93e19
Compare
|
@ferbncode made the suggested changes :) |
ferbncode
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch, the user does not need to check the radio button, by clicking on the row itself the corresponding radio button gets checked.