z88dk : init at unstable-2018-02-20 #35039
Conversation
| @@ -0,0 +1,60 @@ | |||
| --- /nix/store/lqr8s3yi8gn98gf3xybrmxg2dj1d4li2-source/Makefile 1970-01-01 01:00:01.000000000 +0100 | |||
There was a problem hiding this comment.
This patch looks odd to me, is it possible to avoid referring to store paths here? Perhaps it'd be better to modify the PREFIX define using sed or something instead.
There was a problem hiding this comment.
I don't see the problem here, this line is just to say it's a reference ... you can replace with what you want, the thing is that it a huge directory, so i don' t over copy but diff . I think it could be a good thing to have such store , it shows that you diff from the real nix fetched sources ... anyway ... the better is the worse ennemie of the good. Where should i past my time, fix random reviewer suggestion ...
There was a problem hiding this comment.
The issue is that you're checking in a fairly large diff compared to a single line of sed. What is more it seems the diff would have to be updated on each bump, given that it refers to specific store paths.
There was a problem hiding this comment.
i spend 2 days on that. I tried to fix the latest stable first until try to have working library in last time. It took very very long time to compile this stuff, each iteration is very long. It results in a 180MB of compiler + libraries. just to say, the value. I'm using it with caprice32 ... How i see the stuff : "Release early, release often" .
There was a problem hiding this comment.
Well, the patch will likely break the next time the version is bumped, unless you can show that patch will apply cleanly upon a version bump.
| @@ -1,5 +1,5 @@ | |||
| --- /nix/store/lqr8s3yi8gn98gf3xybrmxg2dj1d4li2-source/Makefile 1970-01-01 01:00:01.000000000 +0100 | |||
| +++ lqr8s3yi8gn98gf3xybrmxg2dj1d4li2-source/Makefile 2018-02-16 13:28:44.979280387 +0100 | |||
| --- joachifm-rtfm/Makefile 1970-01-01 01:00:01.000000000 +0100 | |||
There was a problem hiding this comment.
the origin of diff is not a problem, how can i spend my time fixing real stuff and doing good job ... and my sense of humor is like that :) i would prefer to keep the first one since it doesn't matter ...
There was a problem hiding this comment.
i should not have to edit a patch file generated by diff -Naur , and i would prefer fixing upstream later.
bignaux
changed the title
|
|
||
| install: install-clean | ||
| - install -d $(DESTDIR)/$(prefix) $(DESTDIR)/$(prefix_share)/lib | ||
| + install -d $(DESTDIR)/$(prefix) $(DESTDIR)/$(prefix_share)/lib |
There was a problem hiding this comment.
What is the functional difference here?
There was a problem hiding this comment.
nothing, something remove trailing whitespaces and my diff is a bit bigger than it could. But btw, i'd prefer fix that upstream later.
There was a problem hiding this comment.
It might be helpful to refer to a pull request, if it exists - Then future contributor have an easier time to update z88dk, if changes were applied upstream.
There was a problem hiding this comment.
sure, i did it for squashfuse, but i wont do that for z88dk for the moment (i can't contribute all project with fixes, and i need to use more z88dk to do so). I think "Release early, release often" was a good principle . I spent two day on this , i think future contributor would prefer modify existing not perfect derivation than start from scratch. Btw i've 6 open PR for nix, so i see the quality required is very high for new derivation.
There was a problem hiding this comment.
Your open PR requests are more likely related to backlog nixpkgs maintainer have due lack of time.
There was a problem hiding this comment.
ok. As you can see, i commit upstream project i do nix derivation, but sometime, i don't want to waste time to argue , and this patch was some of waste of time. They modify this makefile very often, since z88dk team are in a newlib , new compatibility with sdcc and so, that this was just a not so quick fix to let it works in nix and make stuff with.
There was a problem hiding this comment.
they were pretty quick merging the change btw: z88dk/z88dk#612
There was a problem hiding this comment.
i've to admit. and i was quick to merge the fixing on #fc094db . I've other things to fix as examples optional installation and others stuff. But i'm happy to see nix curators are alive, i've so much to do in it.
bignaux
changed the title
At this point: - Cannot delete properly (so no good for input) - needs a custom fgets_cons since fonts are proportional and we can't 8 - space - 8 to clear the last character - Can't set colours - Scrolling is only in character increments - Fixed window size of the whole screen - Screen needs to be cleared before use or we end up xor with the tape loading status - No fzx_* C API Switch in with -pragma-redirect:fputc_cons=fputc_cons_fzx and configure the font with -pragma-redirect:CRT_FONT_FZX=_ff....
|
You're very lucky you know, people available as suborb is not frequent on project... btw i've noticed the change and will take that in count next z88dk release. |
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)