dep: enable all platforms #35054
Merged
dep: enable all platforms #35054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
reviewed
Feb 16, 2018
| @@ -21,7 +21,6 @@ buildGoPackage rec { | |||
| homepage = https://github.com/golang/dep; | |||
| description = "Go dependency management tool"; | |||
| license = licenses.bsd3; | |||
| platforms = platforms.linux; | |||
There was a problem hiding this comment.
Can you use platforms.all instead? That way we don't rely on the default value being sensible.
There was a problem hiding this comment.
Sure, just a moment.
nicknovitski
force-pushed
the
patch-3
branch
from
4dbc69c
to
70a85de
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We use this tool on darwin and have noticed it builds perfectly fine. According to the scripts and binary releases in its repo, it supports all the platforms nixpkgs does.
Things done
build-use-sandboxinnix.confon non-NixOS)./result/bin/)