Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos.test.dockerTools: add more tests #35048

Merged
merged 1 commit into from Feb 17, 2018
Merged

nixos.test.dockerTools: add more tests #35048

merged 1 commit into from Feb 17, 2018

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Feb 16, 2018

Motivation for this change

To test more

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member Author

nlewo commented Feb 16, 2018

@GrahamcOfBorg test docker-tools

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

docker: exit status 1
syncing
docker: running command: sync
docker: exit status 0
test script finished in 62.51s
cleaning up
killing docker (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-docker-tools.drv-0/vde1.ctl': Directory not empty
/nix/store/pqwhcslk3ydi30hmz4j6d8g3ayfk94q2-vm-test-run-docker-tools

@Mic92 Mic92 merged commit 431c004 into NixOS:master Feb 17, 2018
@Profpatsch
Copy link
Member

Profpatsch commented Feb 17, 2018 •
edited

I was hesitant to pull in a dependency like nginx just for this test; can we find a solution to test runAsRoot with less overhead?

It should suffice to just touch a file and then check inside the image if that file is created by root.

@nlewo
Copy link
Member Author

nlewo commented Feb 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlewo @GrahamcOfBorg @Profpatsch @Mic92