Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postman : 5.5.2 -> 5.5.3 #35201

Merged
merged 1 commit into from Apr 25, 2018
Merged

postman : 5.5.2 -> 5.5.3 #35201

merged 1 commit into from Apr 25, 2018

Conversation

xurei
Copy link
Contributor

@xurei xurei commented Feb 19, 2018

Motivation for this change

Version update.
Also contains a fix for the desktop icon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg build postman

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘postman-5.5.3’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/development/web/postman/default.nix:91 has an unfree license (‘postman’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘postman-5.5.3’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/web/postman/default.nix:91 has an unfree license (‘postman’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Package ‘postman-5.5.3’ in /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/pkgs/development/web/postman/default.nix:91 has an unfree license (‘postman’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

adisbladis
adisbladis reviewed Feb 20, 2018
View reviewed changes
pkgs/development/web/postman/default.nix
@@ -16,10 +16,15 @@ stdenv.mkDerivation rec {

buildPhase = ":"; # nothing to build

icon = fetchurl {
url = "https://www.getpostman.com/img-rebrand/logo.png";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks likely to break in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namely the checksum.

Copy link
Contributor Author

@xurei xurei Feb 20, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't like it either. The icon is in the package that is downloaded initially but I can't find any example using an icon from this package. Is there any way to do that ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could take it from here: https://raw.githubusercontent.com/gilbarbara/logos/b595a2b3ecc933b77aa286bc9b76645a3203920e/logos/postman.svg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or upload it somewhere like archive.org

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not take it from the software tarball ?

I get that it's useful to download an icon if there is none in the main package, but why can't I use the one from the package if there is ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should of course take it from the source tarball if there is one. Nobody mentioned it because everyone assumed there isn't probably an icon anymore as you added fetching it from the website.

Copy link
Contributor Author

@xurei xurei Feb 28, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpletz could you show me an example of how to do that ?
My problem is that I can't find an example doing that.
What I want is this :

  src = fetchurl {
    url = "https://dl.pstmn.io/download/version/${version}/linux64";
    sha1 = "BC0C6117BEC6D1638FD18A0E2A580617669A9297";
    name = "${name}.tar.gz";
  };

  icon = doSomethingAboutTheDownloadedArchive {}; # <--- this is what I can't figure

  desktopItem = makeDesktopItem {
    name = "postman";
    exec = "postman";
    icon = "${icon}";
    comment = "API Development Environment";
    desktopName = "Postman";
    genericName = "Postman";
    categories = "Application;Development;";
  };

(the icon path is /share/postman/resources/app/assets/icon.png)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also specify the icon name:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/games/rocksndiamonds/default.nix#L16
and install it into the right location: https://github.com/NixOS/nixpkgs/blob/master/pkgs/games/rocksndiamonds/default.nix#L36

@matthewbauer matthewbauer merged commit edf5548 into NixOS:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

@Mic92 Mic92 Mic92 left review comments

@fpletz fpletz fpletz left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xurei @adisbladis @GrahamcOfBorg @Mic92 @fpletz @matthewbauer